Skip to content

Remove --force from vendor hermes command #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 4, 2025
Merged

Remove --force from vendor hermes command #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/tender-laws-admire.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"react-native-node-api": patch
---

Don't instruct users to pass --force when vendoring hermes
2 changes: 1 addition & 1 deletion packages/host/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ if (!System.getenv("REACT_NATIVE_OVERRIDE_HERMES_DIR")) {
"React Native Node-API needs a custom version of Hermes with Node-API enabled.",
"Run the following in your Bash- or Zsh-compatible terminal, to clone Hermes and instruct React Native to use it:",
"",
"export REACT_NATIVE_OVERRIDE_HERMES_DIR=\$(npx react-native-node-api vendor-hermes --silent --force)",
"export REACT_NATIVE_OVERRIDE_HERMES_DIR=\$(npx react-native-node-api vendor-hermes --silent)",
"",
"And follow this guide to build React Native from source:",
"https://reactnative.dev/contributing/how-to-build-from-source#update-your-project-to-build-from-source"
Expand Down
2 changes: 1 addition & 1 deletion packages/host/src/node/gradle.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ describe(
);
assert.match(
stderr,
/export REACT_NATIVE_OVERRIDE_HERMES_DIR=\$\(npx react-native-node-api vendor-hermes --silent --force\)/,
/export REACT_NATIVE_OVERRIDE_HERMES_DIR=\$\(npx react-native-node-api vendor-hermes --silent\)/,
);
assert.match(
stderr,
Expand Down
Loading