Fix weak-node-api framework verification count for all Apple targets #336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: kraenhansen <1243959+kraenhansen@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Verify dependency on weak-node-api framework
Fix weak-node-api framework verification count for all Apple targets
Nov 15, 2025
Copilot finished work on behalf of
kraenhansen
November 15, 2025 09:23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI verification step was checking for 4 occurrences of
weak-node-api.frameworkinotooloutput, but the ferric Apple build produces 7 frameworks across all targets.Changes
.github/workflows/check.ymlverification from 4 to 7 expected occurrencesThe verification properly confirms all Apple frameworks link against
weak-node-api.frameworkvia@rpath/weak-node-api.framework/weak-node-api.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.