Skip to content

Fix weak-node-api framework verification count for all Apple targets #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: kh/check-ferric-needed
Choose a base branch
from
Draft

Fix weak-node-api framework verification count for all Apple targets #336

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
96c5312
Initial plan
Copilot Nov 15, 2025
11ff8bf
Fix weak-node-api verification count from 4 to 7
Copilot Nov 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,8 +305,8 @@ jobs:
diff expected-lipo-output.txt lipo-output.txt
# Verify weak-node-api linking
WEAK_NODE_API_COUNT=$(grep -c "@rpath/weak-node-api.framework/weak-node-api" otool-output.txt)
if [ "$WEAK_NODE_API_COUNT" -ne 4 ]; then
echo "Expected 4 occurrences of @rpath/weak-node-api.framework/weak-node-api, found $WEAK_NODE_API_COUNT"
if [ "$WEAK_NODE_API_COUNT" -ne 7 ]; then
echo "Expected 7 occurrences of @rpath/weak-node-api.framework/weak-node-api, found $WEAK_NODE_API_COUNT"
cat otool-output.txt
exit 1
fi
Expand Down
Loading