fix: wait for sandbox ready element instead of fixed sleep in harness beforeAll#32
Merged
Conversation
CAMOBAP
force-pushed
the
fix/harness-render-timeout
branch
2 times, most recently
from
e652fc5 to
b107868
Compare
…for CI - SandboxReactNativeView wrapper already unwraps e.nativeEvent.data before calling onMessage, so msg IS the data directly (not msg.data). iOS sends an object, Android sends a JSON string — handle both with typeof check. - Switch beforeAll to waitFor/queryByTestId to avoid findByTestId 3-arg API - Use a sibling hidden View for sandbox-ready marker instead of passing testID directly to SandboxReactNativeView: changing testID on the native view while the sandbox is running causes the iOS sandbox to restart, leading to a native crash during test execution. - Reset sandboxReady to false on substitution toggle so the sandbox-ready marker disappears and reappears once the new sandbox is ready; replace the fixed 3s sleep in setSubstitution with a proper waitFor. - Increase bridgeTimeout from default 60s to 120s so iOS CI simulator has enough time to install and boot the app after a long Xcode build. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
CAMOBAP
force-pushed
the
fix/harness-render-timeout
branch
from
b107868 to
da1bdbc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.