Conversation
README.md
Outdated
| +if [[ -f "$PODS_ROOT/../.xcode.env.local" ]]; then | ||
| +source "$PODS_ROOT/../.xcode.env.local" | ||
| +fi | ||
| +export CONFIG_CMD="dummy" |
Collaborator
There was a problem hiding this comment.
Why export CONFIG_CMD?
mdjastrzebski
approved these changes
Jan 27, 2025
| { | ||
| name: '--config-cmd [string]', | ||
| description: | ||
| 'Hack for Xcode build script pointing to wrong bundle command that recognizes this flag.', |
Contributor
There was a problem hiding this comment.
should we mark with something like (internal)? because it shouldn't be for external use
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This code in RN core points to some custom
bundlescript ifCLI_PATHenv variable is not set, and this custom bundle script expects--config-cmdto be present.As a way to work around it, I'm adding extra integration instructions to the docs to edit "Bundle React Native code and images" Build Phase, setting custom
CLI_PATHandCONFIG_CMD, and add a dummy--config-cmdcommand to Metro'sbundlecommand (Re.Pack already supports that)Credits to @jbroma for testing this in prod and integrating into Re.Pack in callstack/repack#869
Test plan
Running:
works without installing RNC CLI