fix(redux-devtools-plugin): avoid duplicate snapshot on panel connect#290
Merged
Conversation
Remove redundant request-state command on panel mount since start already enables monitoring and sends the initial state. Document maxAge memory usage and OOM risks on React Native.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
request-statepanel command on connect;startalready enables monitoring and sends the initial lifted-state snapshot.maxAgememory implications and Android OOM risk for large Redux stores in the plugin README and website docs.Fixes #287 (partially — reduces peak memory on panel open; large stores may still need lower
maxAgeorstateSanitizer).Test plan
pnpm --filter @rozenite/redux-devtools-plugin typecheckpnpm --filter @rozenite/redux-devtools-plugin lintpnpm exec vitest run --config packages/redux-devtools-plugin/vite.config.ts