General improvements

[calonso]

• Add more rubies to the CI matrix
• Improved gem structure according to RubyGems guides
• Removed boilerplate code on the spec_helper file.
• Fixed a Forwardable loading issue (kudos @Faz95210)

[calonso]

Any comment anyone? I'll leave it here a couple of days just in case.

[elhu]

I'll have a quick look in the morning!

[calonso]

Hi @elhu, did you had time to have a look at this?

[elhu]

Just a couple questions/comments, everything looks good to me otherwise.

[elhu]

Just curious, what's the motivation behind removing the version file?

[calonso]

To avoid having to require the gem's files in this file. It is a recommendation I took from ruby gems.org

[elhu]

Why do we depend on activesupport exactly?

[calonso]

I think it is a dependency that builder gem brings. I had to fix it because the current version is 5.x and it is not compatible with Ruby <= 2.1.x

[elhu]

Hmm, weird, there's nothing about activesupport in builder's dependencies: https://rubygems.org/gems/builder.

I think forcing the requirement here is a bad idea, since projects using rails 5 depend on activesupport ~> 5.0.

If it's for test purpose, we need to have a build matrix with different version of activesupport depending on the ruby version.
I did something like that in https://github.com/elhu/peastash.

If we actually need it at runtime and not just in specs, we need to:

• Figure out where it comes from
• See if we can't just leave the dependency there and let bundler sort it out

[calonso]

Ok, so I've just discovered it is a factory_girl's dependency so I assume we should do the build matrix you suggest

[elhu]

Then it might be simpler to just register the dependency as a dev-time dependency, no?

spec.add_development_dependency 'activesupport', '~> 4.2'

This way, this requirement is for dev only and has no impact on people trying to add the gem to their projects?

[calonso]

Cool, this looks much better. /cc @elhu

[elhu]

Looks good to me 👍