Update cli.py #40
Merged
Update cli.py #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmorrell
approved these changes
Sep 18, 2024
Member
tmorrell
left a comment
tmorrell
left a comment
There was a problem hiding this comment.
Good to go once message handling is updated
caltechdata_api/cli.py
Outdated
| rec_id = response | ||
| print( | ||
| if production == True: | ||
|
|
Member
There was a problem hiding this comment.
I would set a variable for the URL based on production. That way we can have just one copy of the message
Member
|
Will close #39 |
tmorrell
reviewed
Sep 18, 2024
| record_id, metadata, token, production=production, publish=False | ||
| ) | ||
| if response: | ||
| print("Metadata edited successfully.") |
Member
There was a problem hiding this comment.
You'll also need to update line 554, 558, 594, and 567
-test
Collaborator
Author
|
added the function to do the printing text and use that. In edit, checked the URL template to appropriate uploads link as well. waiting for approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-test