Conversation
There was a problem hiding this comment.
Pull request overview
Updates the release tagging script to prepend a v to newly created Git tags, aligning tag naming with vMAJOR.MINOR.PATCH conventions.
Changes:
- Prefixes the computed tag with
vbefore creating the annotated Git tag. - Improves the final output instructions by explicitly listing the push commands.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| echo "Latest branch: $BRANCH" | ||
| echo "Latest tag: $LATEST_TAG" | ||
| echo "New tag: $NEW_TAG (files will use ${NEW_FILE_VER})" |
There was a problem hiding this comment.
The script logs New tag: $NEW_TAG before the v prefix is applied later, so the printed “New tag” won’t match the tag that actually gets created (e.g., logs 1.2.3 but creates v1.2.3). Consider either applying the prefix before the logging, or logging a separate NEW_GIT_TAG/TAG_NAME variable that matches what will be pushed.
| # Commit, tag and push | ||
| NEW_TAG="v${NEW_TAG}" | ||
| git commit -m "chore(release): bump to ${NEW_TAG}" || echo "No changes to commit" |
There was a problem hiding this comment.
NEW_TAG is initially a plain semver used for file versions, then it is mutated to include the v prefix for Git tagging. Reusing the same variable for two different meanings makes the flow harder to follow and can lead to subtle mistakes if more steps are added between version updates and tagging. Use distinct variables (e.g., NEW_VERSION for files and NEW_TAG/NEW_GIT_TAG for the Git tag) to keep responsibilities clear.
Adds
vprefix to tags