Skip to content

v prefix#204

Merged
bwalsh merged 1 commit intofix/timeoutfrom
fix/version
Feb 11, 2026
Merged

v prefix#204
bwalsh merged 1 commit intofix/timeoutfrom
fix/version

Conversation

@bwalsh
Copy link
Contributor

@bwalsh bwalsh commented Feb 11, 2026

Adds v prefix to tags

Copilot AI review requested due to automatic review settings February 11, 2026 00:32
@bwalsh bwalsh merged commit d1e39cc into fix/timeout Feb 11, 2026
11 of 15 checks passed
@bwalsh bwalsh deleted the fix/version branch February 11, 2026 00:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the release tagging script to prepend a v to newly created Git tags, aligning tag naming with vMAJOR.MINOR.PATCH conventions.

Changes:

  • Prefixes the computed tag with v before creating the annotated Git tag.
  • Improves the final output instructions by explicitly listing the push commands.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 116 to 118
echo "Latest branch: $BRANCH"
echo "Latest tag: $LATEST_TAG"
echo "New tag: $NEW_TAG (files will use ${NEW_FILE_VER})"
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The script logs New tag: $NEW_TAG before the v prefix is applied later, so the printed “New tag” won’t match the tag that actually gets created (e.g., logs 1.2.3 but creates v1.2.3). Consider either applying the prefix before the logging, or logging a separate NEW_GIT_TAG/TAG_NAME variable that matches what will be pushed.

Copilot uses AI. Check for mistakes.
Comment on lines 143 to 145
# Commit, tag and push
NEW_TAG="v${NEW_TAG}"
git commit -m "chore(release): bump to ${NEW_TAG}" || echo "No changes to commit"
Copy link

Copilot AI Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NEW_TAG is initially a plain semver used for file versions, then it is mutated to include the v prefix for Git tagging. Reusing the same variable for two different meanings makes the flow harder to follow and can lead to subtle mistakes if more steps are added between version updates and tagging. Use distinct variables (e.g., NEW_VERSION for files and NEW_TAG/NEW_GIT_TAG for the Git tag) to keep responsibilities clear.

Copilot uses AI. Check for mistakes.
bwalsh added a commit that referenced this pull request Feb 11, 2026
* bump data-client
* v prefix (#204)
* bug/Install-workflow-fails-with-404 #205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments