Skip to content

fix: updates commonalities, icm, and version#32

Merged
caubut-charter merged 17 commits intomainfrom
19-commonalities-pass-for-corrections
Mar 7, 2025
Merged

fix: updates commonalities, icm, and version#32
caubut-charter merged 17 commits intomainfrom
19-commonalities-pass-for-corrections

Conversation

@caubut-charter
Copy link
Copy Markdown
Contributor

What type of PR is this?

Add one of the following kinds:

  • subproject management

What this PR does / why we need it:

Prep for release. Updates commonalities and ICM.

Which issue(s) this PR fixes:

Fixes #19

Special notes for reviewers:

Sets the release version.

Changelog input

- [#19](https://github.com/camaraproject/NetworkAccessManagement/issues/19) Updates commonalities and ICM.

Additional documentation

@caubut-charter caubut-charter linked an issue Jan 16, 2025 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 16, 2025

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 2 0 0.03s
✅ OPENAPI spectral 1 0 3.14s
✅ REPOSITORY git_diff yes no 0.0s
✅ REPOSITORY secretlint yes no 0.81s
✅ YAML yamllint 1 0 0.76s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Copy Markdown
Contributor

@RandyLevensalor RandyLevensalor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some updates to ICM and terminology below.

Comment thread code/API_definitions/network-access-management.yaml Outdated
Comment thread code/API_definitions/network-access-management.yaml Outdated
Comment thread code/API_definitions/network-access-management.yaml Outdated
Comment thread code/API_definitions/network-access-management.yaml Outdated
benhepworth
benhepworth previously approved these changes Feb 5, 2025
Copy link
Copy Markdown
Contributor

@benhepworth benhepworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - I agree with Randy's suggestions to use the new terminology (API Producer and API Consumer throughout).

…Readiness-Checklist.md

Co-authored-by: Randy Levensalor <randymartini@gmail.com>
caubut-charter and others added 4 commits March 6, 2025 21:28
Co-authored-by: Randy Levensalor <randymartini@gmail.com>
…ss-for-corrections' into 19-commonalities-pass-for-corrections
@caubut-charter caubut-charter merged commit 3dd70eb into main Mar 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Commonalities pass for corrections

3 participants