-
Notifications
You must be signed in to change notification settings - Fork 24
NumberVerification over WiFi #174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Jorge Garcia Hospital <129095857+jgarciahospital@users.noreply.github.com>
Co-authored-by: Jorge Garcia Hospital <129095857+jgarciahospital@users.noreply.github.com>
Co-authored-by: Jorge Garcia Hospital <129095857+jgarciahospital@users.noreply.github.com>
|
@jgarciahospital many thanks for your review and suggestions. I am trying to address them all and commit your suggestions if I agree with them. Then I "resolve the conversation". I hope my way of doing this is OK with you. |
tanjadegroot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, some rewording / clarifications added
Co-authored-by: Tanja de Groot <87864067+tanjadegroot@users.noreply.github.com>
e0c8056
Co-authored-by: Tanja de Groot <87864067+tanjadegroot@users.noreply.github.com>
|
I've tried to include a comment directly (didn't work for me-sorry): but could we please add a clarification before the flow, indication that an aggregator may also be part of the flow->"Note that the diagram shows just an example of a direct integration from developer's application and the API Provider's auth server (an aggregator may also be part of the flow): |
@ECORMAC, my view:
My suggestion is to address further changes in this section within #94, which we agreed to include in a later version. |
This is fine for me to add this - @hdamker @AxelNennker @fernandopradocabrillo any view on your side? |
Fine for me, but maybe not necessary and not in scope of this PR. |
I prefer to leave it out of this PR and address it later since we are going to do some rework. Axel mentioned to also include diagrams with mermaid, etc. I think we can plan it with more time so it'll be more detailed. |
|
Ok that sounds like a plan. |
bigludo7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm :)
fernandopradocabrillo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
bigludo7
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What type of PR is this?
Add one of the following kinds:
What this PR does / why we need it:
Currently NumberVerification relies on network-based authentication, which means that the user's phone needs to be on a mobile connection because the phone's IP-address is mapped to subscriber's MSISDN.
This means that NumberVerification does not work over WiFI.
This PR does not change the NumberVerification API but changes how the API Consumer gets an access token for the API.
Fixes #86 #165
Changelog input
Additional documentation
GSMA TS.43 standard on temporary tokens and "operations"
https://www.gsma.com/get-involved/working-groups/gsma_resources/ts-43-v12-0-service-entitlement-configuration/