fix(canary): skip HTML-comment identity marker when extracting title#219
Merged
hdamker merged 1 commit intocamaraproject:validation-frameworkfrom Apr 23, 2026
Conversation
The RA bot's post-bot-comment action prepends an identity marker of the form '<!-- release-bot:<release-tag> -->' as line 1 of every reply. _first_nonblank_line/_match_comment_title returned that marker as the title and failed to match the visible '**✅ Snapshot created …' line beneath it. Observed on run 24821023555 where the round-trip actually executed successfully but the canary scored it as a fire-phase FAIL. Rename _first_nonblank_line → _first_visible_line and skip lines that are pure HTML comments (anchored '^\s*<!--.*?-->\s*$'). Lines that mix content with a comment are NOT skipped — keeps the regex strict. Comprehensive test coverage for single-marker, multi-marker, inline- comment, empty body, and marker-only body.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug
What this PR does / why we need it:
The RA bot's
post-bot-commentaction prepends an identity marker of the form<!-- release-bot:<release-tag> -->as line 1 of every reply (programmatic lookup key). The canary's_first_nonblank_line+_match_comment_titlegrabbed that marker as the "title" and failed to match the visible**✅ Snapshot created …line beneath it.Observed on run 24821023555 (post-tooling#218 merge). The round-trip actually executed green on ReleaseTest — snapshot
r1.2-7c6a6e8was created, PR #96 opened — but the canary misclassified the result as fire-phase FAIL.Rename
_first_nonblank_line→_first_visible_lineand skip lines that are pure HTML comments (anchored^\s*<!--.*?-->\s*$). Lines that mix content with an inline comment are not skipped.Which issue(s) this PR fixes:
Fixes #
Related to camaraproject/ReleaseManagement#379.
Special notes for reviewers:
73/73 tests pass. New coverage: single marker + title, multiple markers + blank lines, inline-comment line (not skipped), empty body, and marker-only body.
Post-merge I'll manually
/discard-snapshoton ReleaseTest#93 to clear the stalesnapshot-activeleft from the last canary attempt, then dispatch the canary to confirm the round-trip scores as 5/5 green.Changelog input
Additional documentation
This section can be blank.