Skip to content

Feature: mint notifications#16

Merged
zacck-zz merged 9 commits into
masterfrom
feature/mint_notifications
Nov 14, 2019
Merged

Feature: mint notifications#16
zacck-zz merged 9 commits into
masterfrom
feature/mint_notifications

Conversation

@zacck-zz
Copy link
Copy Markdown
Contributor

@zacck-zz zacck-zz commented Nov 13, 2019

Changes Proposed

  • Add database trigger and function for mints
  • test that mint notifications are broadcasted
  • Broadcast mint notifications

@zacck-zz zacck-zz requested a review from lucca65 November 13, 2019 10:28
@zacck-zz zacck-zz force-pushed the feature/mint_notifications branch from f859b11 to f076980 Compare November 13, 2019 12:39
Copy link
Copy Markdown
Member

@lucca65 lucca65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, as always. One thing pops up to my mind though:

As you can see here the issue action is an inline action. Our demux solution currently don't support inline actions so we won't have the feature done in the end.

I think the best course of action is to finish up this and the frontend pull request and then start working on the Demux side to see if we can somehow get inline actions. Maybe there are updates to demux that I'm not aware of!

@lucca65
Copy link
Copy Markdown
Member

lucca65 commented Nov 14, 2019

In anyway, this PR is approved, you can merge it!

@zacck-zz
Copy link
Copy Markdown
Contributor Author

@lucca65 we should open an issue to deal with the demux situation ...

@zacck-zz zacck-zz merged commit 9f6824b into master Nov 14, 2019
@zacck-zz zacck-zz deleted the feature/mint_notifications branch November 14, 2019 07:28
lucca65 pushed a commit that referenced this pull request May 17, 2026
* Minor feature bump for issue/mint notifications

* Create function and trigger to run when a mint is added to the database

* Build datastructure for mint and add mint_factory for testing

* Add test for mint notification and format file to remove trailing spaces

* Amend variable and alert information

* Add a callback to handle mint triggers

* Add a function to handle notifying mint receivers

* Add mints to the public schema

* Expose mints from a community
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants