Add NotificationHistory table, with GraphQL, save shop and transfer notifications#5
Merged
Merged
Conversation
zacck-zz
reviewed
Oct 3, 2019
Contributor
|
@lucca65 can I add a field that returns the number of unread notifications and a mutation for marking notifications as read to this PR ? |
zacck-zz
reviewed
Oct 3, 2019
zacck-zz
suggested changes
Oct 3, 2019
zacck-zz
reviewed
Oct 4, 2019
| defmodule BeSpiral.NotificationHistoryTest do | ||
| use BeSpiral.DataCase | ||
|
|
||
| describe "notification_history" do |
Contributor
There was a problem hiding this comment.
These tests are valid though, Ill add them too
Contributor
There was a problem hiding this comment.
Hey @lucca65 are these fields added yet? I can't seem to see their implementations
Member
Author
There was a problem hiding this comment.
Member
Author
There was a problem hiding this comment.
Contributor
There was a problem hiding this comment.
@lucca65 I mean the resolvers, I can find one for all of a users notifications but I am not seeing one for the single notification ...
Member
Author
There was a problem hiding this comment.
no, we only have them in a list!
Contributor
|
@lucca65 merging this as I feel it's done for now |
zacck-zz
force-pushed
the
feature/notification_history
branch
from
8f6d837 to
86395f6
Compare
lucca65
added a commit
that referenced
this pull request
May 17, 2026
…otifications (#5) * Add NotificationHistory table, with GraphQL, save shop and transfer notifications * Remove empty spaces in line endings * bump version * Use utc_datetime instead of naive_datetime for notification history timestamps * Make notification graphql query a non_null list * Adjust pattern matching * Add union type for notification * Make sale_history's amount non_null * Add NotificationHistory factory * Test that we can count unread notifications * Implement schema resolvers and types to count unread notifications * Implement context function to collect unread notification count * Test that notification history can be marked as read * Implement schema types and functions to allow marking a notification as read * Implement fetching and flagging a notification as read * Remove unnecessary default parameter * Move tranfer and sale history collector to context to utilize business logic * remove empty test file * Clean up merge
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to implemente the backend part for the notification history screen, seen here:
https://projects.invisionapp.com/d/main#/console/17335338/367779185/preview