Merged
Conversation
✅ Deploy Preview for cambiatus-elm-book ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy done!
To edit notification comments on pull requests, go to your Netlify site settings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What issue does this PR close
Closes #758
Changes Proposed ( a list of new changes introduced by this PR)
Gizra/elm-debouncerso we don't fire multiple queries that will end up being discarded anywayHow to test ( a list of instructions on how to test this PR)
You need a combination of keystrokes that can cause the bug (described in the issue). You can try to find one here. An example in the Buss community is having
acin the search, then deletingcand typing it again quickly.You can then test that combination in the deploy of this PR.