Skip to content

Conversation

@jjyaoao
Copy link
Contributor

@jjyaoao jjyaoao commented Mar 17, 2025

Description

#1876
update pyproject.toml to add one more dependency group for owl, only add dependencies required by owl

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTION guide (required)
  • I have linked this PR to an issue using the Development section on the right sidebar or by adding Fixes #issue-number in the PR description (required)
  • I have checked if any dependencies need to be added or updated in pyproject.toml and uv lock
  • I have updated the tests accordingly (required for a bug fix or a new feature)
  • I have updated the documentation if needed:
  • I have added examples if this is a new feature

If you are unsure about any of these, don't hesitate to ask. We are here to help!

Comment on lines 186 to 228
owl = [
"chunkr-ai>=0.0.41",
"docx2markdown>=0.1.1",
"mcp-simple-arxiv==0.2.2",
"mcp-server-fetch==2025.1.17",
]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to include all toolkit related dependencies, please test locally after the update~

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to include all toolkit related dependencies, please test locally after the update~

Hi, this update can run the example/run.py in owl. you can review it~

@Wendong-Fan Wendong-Fan changed the title update dependency for owl chore: update dependency for owl Mar 17, 2025
@jjyaoao jjyaoao self-assigned this Mar 19, 2025
Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @jjyaoao 's contribution and sorry for the late review, left some comments, we also need to run uv lock to update the lock file

pyproject.toml Outdated
"arxiv>=2.1.3,<3",
"arxiv2text>=0.1.14,<0.2",
"chunkr-ai>=0.0.41",
"docx2markdown>=0.1.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is docx2markdown used for ?

pyproject.toml Outdated
"docx2markdown>=0.1.1",
"mcp-simple-arxiv==0.2.2",
"mcp-server-fetch==2025.1.17",
"xmltodict>=0.13.0,<0.14",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is xmltodict used for ?

@Wendong-Fan Wendong-Fan added the enhancement New feature or request label Mar 27, 2025
@Wendong-Fan Wendong-Fan added this to the Sprint 26 milestone Mar 27, 2025
@Wendong-Fan Wendong-Fan merged commit a39b3ec into master Mar 27, 2025
4 of 6 checks passed
@Wendong-Fan Wendong-Fan deleted the dependency_owl branch March 27, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants