Skip to content

Conversation

@fengju0213
Copy link
Collaborator

@fengju0213 fengju0213 commented Mar 23, 2025

Description

Modify the output format of tools in FunctionTool to use structured output. Add a retry mechanism for tool calls in ChatAgent.
linked #1956

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTION guide (required)
  • I have linked this PR to an issue using the Development section on the right sidebar or by adding Fixes #issue-number in the PR description (required)
  • I have checked if any dependencies need to be added or updated in pyproject.toml and uv lock
  • I have updated the tests accordingly (required for a bug fix or a new feature)
  • I have updated the documentation if needed:
  • I have added examples if this is a new feature

If you are unsure about any of these, don't hesitate to ask. We are here to help!

@fengju0213 fengju0213 requested a review from Wendong-Fan March 23, 2025 04:39
@fengju0213 fengju0213 marked this pull request as draft March 23, 2025 04:41
@fengju0213 fengju0213 marked this pull request as ready for review March 23, 2025 05:37
@fengju0213
Copy link
Collaborator Author

fengju0213 commented Mar 23, 2025

@Wendong-Fan Hi, Wendong,
Should the use of a tool stop in a loop after it fails a retry? Currently, if a tool fails, the next tool is still used. However, the agent may still attempt to call the failed tool again in the next iteration.

@fengju0213 fengju0213 self-assigned this Mar 23, 2025
@Wendong-Fan
Copy link
Member

@Wendong-Fan Hi, Wendong, Should the use of a tool stop in a loop after it fails a retry? Currently, if a tool fails, the next tool is still used. However, the agent may still attempt to call the failed tool again in the next iteration.

hey @fengju0213 ,we need to forbid agent trying to call the failed tool that reach max retry

@fengju0213
Copy link
Collaborator Author

@Wendong-Fan Hi, Wendong, Should the use of a tool stop in a loop after it fails a retry? Currently, if a tool fails, the next tool is still used. However, the agent may still attempt to call the failed tool again in the next iteration.

hey @fengju0213 ,we need to forbid agent trying to call the failed tool that reach max retry

directly removing the failed tools from the tool list might work?

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@fengju0213
Copy link
Collaborator Author

Why are so many files modified?😂 @yanxue7

@yanxue7
Copy link
Collaborator

yanxue7 commented Mar 28, 2025

I merged the master to this repo, and I have reverted the commit yet

@fengju0213
Copy link
Collaborator Author

I merged the master to this repo, and I have reverted the commit yet

but the file changes are still here

@fengju0213
Copy link
Collaborator Author

I merged the master to this repo, and I have reverted the commit yet

I'll open a new pr

@fengju0213 fengju0213 closed this Mar 28, 2025
@fengju0213 fengju0213 deleted the Tao-Sun_WorkSpace branch March 28, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants