refactor: Clean up SingleStepEnv #1985
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
batch size == 1
…he Action model aswell as to single Action support
… size 0 edge case
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
2 tasks
Collaborator
old-hallerite
left a comment
old-hallerite
left a comment
There was a problem hiding this comment.
thanks @Apokryphosx, left some comments
Wendong-Fan
reviewed
Mar 26, 2025
Member
There was a problem hiding this comment.
thanks @Apokryphosx and @hallerite , left some comments and one enhance PR here: #2006 please check and let me know if there's anything we can further discuss
Wendong-Fan
approved these changes
Mar 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We should adopt our StepResult model to have a function to return it as a tuple, and make that the standard in the step function. We also need to fix SingleStepEnv for the batch size == 1 case.
This PR addresses #1984
Checklist
Go over all the following points, and put an
xin all the boxes that apply.Fixes #issue-numberin the PR description (required)pyproject.tomlanduv lockIf you are unsure about any of these, don't hesitate to ask. We are here to help!