Skip to content

Conversation

@saikidev
Copy link
Contributor

@saikidev saikidev commented Mar 25, 2025

Description

Add a new llm provider: ppio.

Checklist

Go over all the following points, and put an x in all the boxes that apply.

  • I have read the CONTRIBUTION guide (required)
  • I have linked this PR to an issue using the Development section on the right sidebar or by adding Fixes #issue-number in the PR description (required)
  • I have updated the tests accordingly (required for a bug fix or a new feature)

@saikidev
Copy link
Contributor Author

saikidev commented Mar 25, 2025

This pr is relatived to add new llm provider: ppio

@fengju0213
Copy link
Collaborator

fengju0213 commented Mar 26, 2025

@saikidev thanks!can you add example and test like 6a39c1a#diff-cccd34af48a94d9606279ca10de626a2a22a552383eacde07d9010fd35585f4e

@fengju0213 fengju0213 self-requested a review March 26, 2025 06:42
@fengju0213
Copy link
Collaborator

You should also modify the __init__.py file under the model directory.

@saikidev
Copy link
Contributor Author

You should also modify the __init__.py file under the model directory.

Thanks! And I have fixed.

Copy link
Collaborator

@GitHoobar GitHoobar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @saikidev

Copy link
Collaborator

@fengju0213 fengju0213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks@saikidev

@saikidev
Copy link
Contributor Author

saikidev commented Apr 7, 2025

thanks@saikidev

@fengju0213

Can you help to merge this PR, Thanks a lot!

@fengju0213
Copy link
Collaborator

thanks@saikidev

@fengju0213

Can you help to merge this PR, Thanks a lot!

yeah,of course,thanks @saikidev

@zjrwtx
Copy link
Collaborator

zjrwtx commented Apr 8, 2025

hello @saikidev ,please resolve the conflicts

@fengju0213
Copy link
Collaborator

@saikidev thanks

@fengju0213 fengju0213 merged commit f53c50e into camel-ai:master Apr 9, 2025
2 of 7 checks passed
Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @saikidev , left some comments below
cc @fengju0213

Comment on lines +98 to +102
def as_dict(self) -> dict[str, Any]:
config_dict = super().as_dict()
if "tools" in config_dict:
del config_dict["tools"] # Currently does not support tool calling
return config_dict
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from https://ppinfra.com/docs/model/llm-function-calling I think it's supporting tool call

Comment on lines +63 to +68
self,
model_type: Union[ModelType, str],
model_config_dict: Optional[Dict[str, Any]] = None,
api_key: Optional[str] = None,
url: Optional[str] = None,
token_counter: Optional[BaseTokenCounter] = None,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to add timeout setting

Comment on lines +57 to +61
@api_keys_required(
[
("api_key", 'PPIO_API_KEY'),
]
)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to add the key to yml config file

@saikidev
Copy link
Contributor Author

@Wendong-Fan I noticed that you have already modified my code. Can I ask when it will be released?

@fengju0213
Copy link
Collaborator

fengju0213 commented Apr 16, 2025

@Wendong-Fan I noticed that you have already modified my code. Can I ask when it will be released?

it is already released @saikidev

@saikidev
Copy link
Contributor Author

@Wendong-Fan I noticed that you have already modified my code. Can I ask when it will be released?

it is already released @saikidev

But I install CAMEL with all dependencies by running "uv pip install -e .", There is no file about PPIO
图片

@fengju0213
Copy link
Collaborator

@Wendong-Fan I noticed that you have already modified my code. Can I ask when it will be released?

it is already released @saikidev

But I install CAMEL with all dependencies by running "uv pip install -e .", There is no file about PPIO 图片

You need to update to the latest version

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants