-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: camel toolkits as mcp server #1999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
keli-wen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I think users can now clearly understand how to use Camel directly as an MCP.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
camel/toolkits/arxiv_toolkit.py
Outdated
|
|
||
| from typing import Dict, Generator, List, Optional | ||
|
|
||
| from mcp.server import FastMCP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems imported but not used?
camel/toolkits/base.py
Outdated
|
|
||
| from typing import List, Optional | ||
|
|
||
| from mcp.server import FastMCP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lazy import to make dependency optional
camel/toolkits/notion_toolkit.py
Outdated
| from notion_client import Client | ||
|
|
||
| self.notion_token = notion_token or os.environ.get("NOTION_TOKEN") | ||
| print(self.notion_token) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clean
camel/utils/mcp.py
Outdated
| import inspect | ||
| from typing import Any, Callable, Optional | ||
|
|
||
| from mcp.server.fastmcp import FastMCP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lazy import to make the dependecy optional
Wendong-Fan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @koch3092 !
Description
PR draft for #1912 :
Checklist
Go over all the following points, and put an
xin all the boxes that apply.Fixes #issue-numberin the PR description (required)pyproject.tomlanduv lockIf you are unsure about any of these, don't hesitate to ask. We are here to help!