Discuss alternatives for getRelayUptimeSeconds error handling

[CKodidela]

Context

In #585 , getRelayUptimeSeconds was patched to wrap
runCommandWithOutput in a try/catch to handle the case where
Docker is not installed. When Docker is missing, spawn emits
an ENOENT error instead of returning a non-zero exit code, which
was causing info --json to crash and break the pre-commit hook.

Problem

The current fix works but is a short-term solution. We should
discuss better long-term alternatives.

Potential Alternatives

• Pre-check if Docker is installed before invoking the command
• TBD

Goal

Agree on a consistent approach so similar issues don't arise in
other command wrappers.

[CKodidela]

@cameri

[CKodidela]

@cameri we can discuss on this issue when you are available

[cameri]

@Mahmoud-s-Khedr since you worked on the CLI migration, do you mind providing your recommendation here?

[Mahmoud-s-Khedr]

HI, @cameri @CKodidela, my recommendation is to solve this in the shared command runner (the layer behind runCommandWithOutput) instead of per call site try/catch.

spawn errors like ENOENT (docker not installed) are a different failure path from non-zero exit codes, and today callers need to know that detail. That’s why info --json crashed.

I’d suggest we standardize runCommandWithOutput to return a normalized result/error model for all cases:

• command not found (ENOENT)
• permission denied (EACCES)
• non-zero exit
• timeout
• terminated by signal

Then callers only apply feature policy:

• optional dependency: degrade gracefully (e.g. null / unknown)
• required dependency: fail with a clear actionable error

This gives us one consistent contract across the CLI and prevents repeating the same class of bug in other wrappers.

What do you think do you this approach?

[CKodidela]

Agreed. Normalizing all failure cases in runCommandWithOutput keeps callers clean and prevents the same bug from recurring elsewhere. A discriminated union on the return type would make the contract explicit.

[CKodidela]

@cameri i can make a PR if this suggestion is agreed upon

[cameri]

Yes, let's move forward with @Mahmoud-s-Khedr recommendation

[CKodidela]

Should I work on this?
If yes can you assign it.

[cameri]

Assigned to you

[Mahmoud-s-Khedr]

@CKodidela feel free to tag me if you need any help with this.

[CKodidela]

Sure