test: update unit tests for NIP-01 compliance changes#480
Merged
Conversation
Update event-repository specs to expect deterministic event ordering by event_id (asc) alongside event_created_at, matching the behavior added in 764ce00. Also update parameterized-replaceable-event-strategy spec to expect only the first dedup key value, matching the change in 7f56d4a. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The accepts package was imported directly in root-request-handler and routes/index but relied on express as an implicit transitive dep. Knip flags this as an unlisted dependency; declare it explicitly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
phoenix-server
force-pushed
the
fix/update-tests-for-nip01-ordering
branch
from
bb76ed1 to
ec30de0
Compare
cameri
approved these changes
Apr 18, 2026
This was referenced Apr 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
event-repositoryspecs to expect deterministicevent_idsecondary sort alongsideevent_created_at, matching the behavior introduced in 764ce00parameterized-replaceable-event-strategyspec to expect only the first dedup key value, matching the behavior change in 7f56d4aBoth commits landed without corresponding test updates, leaving 31 failing tests on
main.Test plan
npm run test:unit)🤖 Generated with Claude Code