test: add NIP-40 standalone expiration integration coverage#528
Merged
cameri merged 11 commits intocameri:mainfrom Apr 21, 2026
Merged
test: add NIP-40 standalone expiration integration coverage#528cameri merged 11 commits intocameri:mainfrom
cameri merged 11 commits intocameri:mainfrom
Conversation
Collaborator
There was a problem hiding this comment.
Pull request overview
Adds standalone (kind 1 / text_note) NIP-40 expiration integration coverage to complement existing NIP-33 expiration tests, plus a small integration-test helper refactor to allow asserting rejected publishes.
Changes:
- Added Gherkin scenarios for expired-in-past, expires-in-future, and post-storage-expiration behavior for kind 1 events.
- Added Cucumber step definitions for publishing expiring text_note events, waiting for expiration, subscribing, and asserting EOSE + counts.
- Added a lower-level
publishEventhelper to observeOKresults without forcing expected success, and reimplementedsendEventon top.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/integration/features/nip-40/nip-40.feature | Adds NIP-40 standalone expiration scenarios for kind 1 events. |
| test/integration/features/nip-40/nip-40.feature.ts | Implements the step definitions to publish expiring events and assert subscription results. |
| test/integration/features/helpers.ts | Introduces publishEvent and refactors sendEvent to allow asserting unsuccessful publishes. |
| .changeset/empty-nip40-tests.md | Adds an “empty” changeset note for the test-only change. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Author
|
Hey @cameri, I resolved the merge conflicts and pushed the updated branch. |
cameri
reviewed
Apr 19, 2026
cameri
reviewed
Apr 20, 2026
cameri
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
test/integration/features/nip-40/nip-40.feature.test/integration/features/nip-40/nip-40.feature.ts.EventTags.ExpirationandEventExpirationTimeMetadataKeyfromsrc/constants/base.ts.test/integration/features/helpers.tsto publish events without forcing expected OK success, so expiration edge cases can be asserted cleanly.Related Issue
Motivation and Context
How Has This Been Tested?
npm run docker:test:integration -- test/integration/features/nip-40/nip-40.featureScreenshots (if appropriate):
Types of changes
Checklist: