Skip to content

Event repo reduced complexity #58

Closed
saranshisatgit wants to merge 4 commits intocameri:mainfrom
Cynsar-Foundation:EventRepo
Closed

Event repo reduced complexity #58
saranshisatgit wants to merge 4 commits intocameri:mainfrom
Cynsar-Foundation:EventRepo

Conversation

@saranshisatgit
Copy link

Description

This is to reduce the footprint of the function that filters event , I am not sure what else to subtract and divide further, open to suggestions,

Related Issue

#46

Motivation and Context

This would help other contributors to understand code easier and make them to contribute or re-use small footprint

How Has This Been Tested?

Yeah ran unit test and integrations tests both seems fine to me.

Screenshots (if appropriate):

Types of changes

  • Non-functional change (docs, style, minor refactor)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my code changes.
  • All new and existing tests passed.

@saranshisatgit
Copy link
Author

Shit , I mixed my DockerFile railway app here

Dockerfile.railwayapp
@cameri
Copy link
Owner

cameri commented Nov 13, 2022

Shit , I mixed my DockerFile railway app here

Also the package lock changes shouldn't be part of this change.

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 3454274447

  • 11 of 11 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 88.678%

Totals Coverage Status
Change from base Build 3452290770: 0.01%
Covered Lines: 725
Relevant Lines: 808

💛 - Coveralls

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@cameri
Copy link
Owner

cameri commented Nov 16, 2022

@saranshisatgit I didn't mean remove the package-lock, but instead to revert your changes to it. When comitting please add files individually so unintended changes don't creep up into your commits

@cameri cameri closed this Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants