Skip to content

fix: maxlimit check to subscription event requests#600

Merged
cameri merged 5 commits intocameri:mainfrom
saniddhyaDubey:fix/issue-598-maxlimit-sub-req
May 3, 2026
Merged

fix: maxlimit check to subscription event requests#600
cameri merged 5 commits intocameri:mainfrom
saniddhyaDubey:fix/issue-598-maxlimit-sub-req

Conversation

@saniddhyaDubey
Copy link
Copy Markdown
Collaborator

Closes #598

Screenshots:

All existing test cases are passing
Screenshot 2026-05-03 at 4 45 31 AM

New test case for the check is added in unit test and passing
Screenshot 2026-05-03 at 4 47 12 AM

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • My code follows the code style of this project.
  • I have added tests to cover my code changes.
  • I added a changeset, or this is docs-only and I added an empty changeset.
  • All new and existing tests passed.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 3, 2026

🦋 Changeset detected

Latest commit: 7d99707

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
nostream Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@saniddhyaDubey saniddhyaDubey changed the title Fix/issue 598 maxlimit sub req fix: maxlimit check to subscription event requests May 3, 2026
@coveralls
Copy link
Copy Markdown
Collaborator

coveralls commented May 3, 2026

Coverage Status

coverage: 65.131% (+0.05%) from 65.082% — saniddhyaDubey:fix/issue-598-maxlimit-sub-req into cameri:main

Comment thread test/unit/handlers/subscribe-message-handler.spec.ts
Comment thread src/handlers/subscribe-message-handler.ts
@cameri cameri merged commit dfa2838 into cameri:main May 3, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] maxLimit setting is advertised in NIP-11 relay info but never enforced on subscription queries

3 participants