Skip to content

Fix under-alignment issues#179

Merged
cameron314 merged 1 commit intocameron314:masterfrom
improbablejan:bugfix/under-alignment
Jan 2, 2020
Merged

Fix under-alignment issues#179
cameron314 merged 1 commit intocameron314:masterfrom
improbablejan:bugfix/under-alignment

Conversation

@improbablejan
Copy link
Copy Markdown
Contributor

Fixes #177

@cameron314
Copy link
Copy Markdown
Owner

It looks like we can't use aligned_storage (I support VS2013 for now): https://stackoverflow.com/q/24045850/21475.
Can we just move the MOODYCAMEL_ALIGNAS to the declaration of elements instead of Block? I think that would be sufficient.

@improbablejan
Copy link
Copy Markdown
Contributor Author

Shame. Yeah, I'll move it.

@improbablejan improbablejan force-pushed the bugfix/under-alignment branch from 0e3ff08 to 3668bd6 Compare January 2, 2020 15:27
@cameron314
Copy link
Copy Markdown
Owner

Thanks for the PR!

@cameron314 cameron314 merged commit c2e768e into cameron314:master Jan 2, 2020
@improbablejan
Copy link
Copy Markdown
Contributor Author

No worries, thanks for the quick turnaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Alignment unit tests fail to compile on macOS

2 participants