Skip to content

Unlock ability to build benchmarks on OSX #333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cameron314 merged 1 commit into from
Feb 27, 2023
Merged

Unlock ability to build benchmarks on OSX #333

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion build/makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,10 @@ ifeq ($(OS),Windows_NT)
PLATFORM_OPTS = -static
TBB_PLATFORM_OPTS = -DUSE_WINTHREAD
else
LD_PLATFORM_OPTS = -lrt
UNAME_S := $(shell uname -s)
Copy link
Copy Markdown
Owner

@cameron314 cameron314 Feb 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not use $(OS)?

Copy link
Copy Markdown
Contributor Author

@cjappl cjappl Feb 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately doesn't work on OSX at least. I based this design off of this pattern:

https://stackoverflow.com/questions/714100/os-detecting-makefile

ifeq ($(UNAME_S),Linux)
LD_PLATFORM_OPTS = -lrt
endif
# -fsanitize=address seems to have a slow memory leak when creating/destroying a lot of threads
#DEBUG_OPTS += -fno-omit-frame-pointer -fsanitize=address
endif
Expand Down