compiler warnings

[kletoz]

Not sure if you want to be C++11 almost-all-warnings compliant, but anyway :)

I can send a small pull request if you want: master...kletoz:fix_warnings

Otherwise, please just close this issue.

$ make
g++  -std=c++11 -Wall -pedantic -pedantic-errors -Wextra -Wcast-align -Wcast-qual -Wpacked -Wsign-compare -Wdeprecated -Wmain -Wcomment -Wconversion -Wdisabled-optimization -Werror -Wfloat-equal -Wformat  -Wignored-qualifiers -Wimport -Wvolatile-register-var -Wformat-y2k -Winit-self -Winvalid-pch  -Wunused-value -Wnon-virtual-dtor -Wwrite-strings -Wredundant-decls -Wmissing-field-initializers -Wstrict-aliasing=2 -Wparentheses -Wuninitialized -Wtrigraphs -Wunreachable-code -Wmissing-braces -Wmissing-include-dirs -Wreturn-type -Wunused -Wsequence-point -Wswitch -Wstack-protector -Wstrict-aliasing -Wold-style-cast -Wchar-subscripts -Wunused-parameter -Wvariadic-macros -Wunknown-pragmas -Wpointer-arith -Wunused-label -Wmissing-declarations -Wformat-security -Wunused-variable -DNDEBUG -O3 -g unittests.cpp ../common/simplethread.cpp -o unittests -pthread
unittests.cpp:437:16: error: use of old-style cast [-Werror,-Wold-style-cast]
                                int size = (int)q.size_approx();
                                           ^    ~~~~~~~~~~~~~~~
unittests.cpp:454:16: error: use of old-style cast [-Werror,-Wold-style-cast]
                                int size = (int)q.size_approx();
                                           ^    ~~~~~~~~~~~~~~~
unittests.cpp:477:16: error: implicit conversion loses integer precision: 'size_t' (aka 'unsigned long') to 'int' [-Werror,-Wshorten-64-to-32]
                                        q.enqueue(i);
                                          ~~~~~~~ ^
unittests.cpp:22:2: error: definition of implicit copy assignment operator for 'Foo' is deprecated because it has a user-declared destructor [-Werror,-Wdeprecated]
        ~Foo()
        ^
./../../readerwriterqueue.h:313:11: note: in implicit copy assignment operator for 'Foo' first required here
                        result = std::move(*element);
                               ^
unittests.cpp:212:22: note: in instantiation of function template specialization 'moodycamel::ReaderWriterQueue<Foo, 512>::try_dequeue<Foo>' requested here
                                ASSERT_OR_FAIL(q.try_dequeue(item));
                                                 ^
4 errors generated.
make: *** [unittests] Error 1

g++  -std=c++11 -Wall -pedantic -pedantic-errors -Wextra -Wcast-align -Wcast-qual -Wpacked -Wsign-compare -Wdeprecated -Wmain -Wcomment -Wconversion -Wdisabled-optimization -Werror -Wfloat-equal -Wformat  -Wignored-qualifiers -Wimport -Wvolatile-register-var -Wformat-y2k -Winit-self -Winvalid-pch  -Wunused-value -Wnon-virtual-dtor -Wwrite-strings -Wredundant-decls -Wmissing-field-initializers -Wstrict-aliasing=2 -Wparentheses -Wuninitialized -Wtrigraphs -Wunreachable-code -Wmissing-braces -Wmissing-include-dirs -Wreturn-type -Wunused -Wsequence-point -Wswitch -Wstack-protector -Wstrict-aliasing -Wold-style-cast -Wchar-subscripts -Wunused-parameter -Wvariadic-macros -Wunknown-pragmas -Wpointer-arith -Wunused-label -Wmissing-declarations -Wformat-security -Wunused-variable -DNDEBUG -O3 stabtest.cpp ../common/simplethread.cpp -o stabtest -pthread
stabtest.cpp:12:29: error: unused parameter 'extra' [-Werror,-Wunused-parameter]
void unpredictableDelay(int extra = 0)
                            ^
stabtest.cpp:19:14: error: unused parameter 'argc' [-Werror,-Wunused-parameter]
int main(int argc, char** argv)
             ^
stabtest.cpp:19:27: error: unused parameter 'argv' [-Werror,-Wunused-parameter]
int main(int argc, char** argv)
                          ^
3 errors generated.
make: *** [stabtest] Error 1

In file included from readerwriterqueue/readerwriterqueue.h:7:0,
readerwriterqueue/atomicops.h: In member function 'bool moodycamel::spsc_sema::Semaphore::timed_wait(uint64_t)':
readerwriterqueue/atomicops.h:540:49: error: use of old-style cast [-Werror=old-style-cast]
     ts.tv_sec += (time_t)(usecs / usecs_in_1_sec);
                                                 ^
readerwriterqueue/atomicops.h:541:48: error: use of old-style cast [-Werror=old-style-cast]
     ts.tv_nsec += (long)(usecs % usecs_in_1_sec) * 1000;

[cameron314]

Might as well fix the warnings, there aren't many :-)

I had a peek at the changes on your branch. Most look good but some would need a few adjustments before I merge:

• I'm hesitant to include CUSTOM_WARNING_FLAGS in the makefiles since warnings vary by compiler version, and I like for the makefile to serve as an concise canonical example where possible
• The usleep should stay commented out in stabtest.cpp
• Your introduction of Foo& operator= made me realize there was a bug in the test that uses it, which I've fixed in a separate commit (thanks!)

[kletoz]

Just send a small pull request.

• I agree about the flags, it's too many :) I used that just in case. No more touch in makefiles.
• I leave the commented code in stabtest.cpp, however it will generate warnings when using all flags. But it's ok, I think.

void unpredictableDelay(int extra = 0)
                            ^
stabtest.cpp:19:14: error: unused parameter 'argc' [-Werror,-Wunused-parameter]
int main(int argc, char** argv)
             ^
stabtest.cpp:19:27: error: unused parameter 'argv' [-Werror,-Wunused-parameter]
int main(int argc, char** argv)
                          ^
3 errors generated.
make: *** [stabtest] Error 1

• Nice fix in constructor/destructor. Didn't see the whole problem there before. Thanks!

This issue can be closed.