ThreadSanitizer complains about missing binary operator before token "("

[nicolacdnll]

When compiling the latest version with gcc version 7.3.0 on Ubuntu 18.04 I get the following error message:

In file included from /opt/readerwriterqueue/readerwriterqueue.h:7:0,
                 from my_source_code;
/opt/readerwriterqueue/atomicops.h:46:44: error: missing binary operator before token "("
 #if defined(__has_feature) && __has_feature(thread_sanitizer)

Reading Clang ThreadSanitizer Documentation I came up with the following fix (I'm not saying it's the best way): change the code at atomicops.h:46 from this

// AE_NO_TSAN
#if defined(__has_feature) && __has_feature(thread_sanitizer)
#define AE_NO_TSAN __attribute__((no_sanitize(thread)))
#else
#define AE_NO_TSAN
#endif

to

#define AE_NO_TSAN
#if defined(__hasi_feature) 
 #if __has_feature(thread_sanitizer)
  #undef AE_NO_TSAN
  #define AE_NO_TSAN __attribute__((no_sanitize(thread)))
 #endif
#endif

My g++ version:

$ g++ -v
Using built-in specs.
COLLECT_GCC=g++
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/7/lto-wrapper
OFFLOAD_TARGET_NAMES=nvptx-none
OFFLOAD_TARGET_DEFAULT=1
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Ubuntu 7.3.0-27ubuntu1~18.04' --with-bugurl=file:///usr/share/doc/gcc-7/README.Bugs --enable-languages=c,ada,c++,go,brig,d,fortran,objc,obj-c++ --prefix=/usr --with-gcc-major-version-only --program-suffix=-7 --program-prefix=x86_64-linux-gnu- --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --with-sysroot=/ --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-vtable-verify --enable-libmpx --enable-plugin --enable-default-pie --with-system-zlib --with-target-system-zlib --enable-objc-gc=auto --enable-multiarch --disable-werror --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-offload-targets=nvptx-none --without-cuda-driver --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu
Thread model: posix
gcc version 7.3.0 (Ubuntu 7.3.0-27ubuntu1~18.04)

[cameron314]

Oops, sorry. This is caused by a recent fix for issue #65 that I botched.

[cameron314]

Try now?

[nicolacdnll]

Problem fixed! Thanks!