Skip to content

feat: [ENG-2136] add section 11 for query and curate history#445

Merged
bao-byterover merged 3 commits intomainfrom
feat/ENG-2136
Apr 20, 2026
Merged

feat: [ENG-2136] add section 11 for query and curate history#445
bao-byterover merged 3 commits intomainfrom
feat/ENG-2136

Conversation

@DatPham-6996
Copy link
Copy Markdown
Collaborator

Moves curate history content from section 3 into a dedicated section 11 (Query and Curate History) alongside query-log history. Adds standard Overview, Use/Do-NOT-use blocks to match the rest of SKILL.md's format.

Summary

  • Problem: Curate history commands were buried inside section 3 (Curate Context) with no dedicated home, and query-log history had no section at all.
  • Why it matters: Agents following SKILL.md couldn't easily discover or reason about history inspection commands; the inconsistent structure made the skill harder to parse reliably.
  • What changed: Added section 11 "Query and Curate History" with Overview, Use/Do-NOT-use blocks, and both brv curate view and brv query-log view command references. Removed the curate history block from section 3.
  • What did NOT change (scope boundary): No CLI behavior, no code, no tests — documentation only.

Type of change

  • Bug fix
  • New feature
  • Refactor (no behavior change)
  • Documentation
  • Test
  • Chore (build, dependencies, CI)

Scope (select all touched areas)

  • TUI / REPL
  • Agent / Tools
  • LLM Providers
  • Server / Daemon
  • Shared (constants, types, transport events)
  • CLI Commands (oclif)
  • Hub / Connectors
  • Cloud Sync
  • CI/CD / Infra

Linked issues

  • Closes #N/A
  • Related #N/A

Root cause (bug fixes only, otherwise write N/A)

N/A

Test plan

  • Coverage added:
    • Unit test
    • Integration test
    • Manual verification only
  • Test file(s): N/A
  • Key scenario(s) covered: Verified section 11 renders correctly and matches the heading/block structure of sections 8–10.

User-visible changes

Agents using the byterover skill will now find history inspection commands under a dedicated section 11 instead of embedded in section 3.

Evidence

  • Trace/log snippets — diff reviewed; section structure confirmed consistent with surrounding sections.

Checklist

  • Tests added or updated and passing (npm test)
  • Lint passes (npm run lint)
  • Type check passes (npm run typecheck)
  • Build succeeds (npm run build)
  • Commits follow Conventional Commits format
  • Documentation updated (if applicable)
  • No breaking changes (or clearly documented above)
  • Branch is up to date with main

Risks and mitigations

None — documentation-only change with no runtime impact.

Moves curate history content from section 3 into a dedicated section 11
(Query and Curate History) alongside query-log history. Adds standard
Overview, Use/Do-NOT-use blocks to match the rest of SKILL.md's format.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 18, 2026

Claude finished @DatPham-6996's task in 57s —— View job


PR Review: feat/ENG-2136 — Add section 11 for query and curate history

  • Gather context and read changed files
  • Analyze diff and review content
  • Post review with score

Summary

Score: 4/5 — Clean, well-structured documentation improvement with one copy-paste error.

What the PR does:

  • Removes the curate history block from section 3 (Curate Context), which is correct — history inspection is a separate concern from curating.
  • Adds a new section 11 "Query and Curate History" that covers both brv curate view and brv query-log view, giving them a dedicated, discoverable home.
  • Follows the established section structure (Overview → Use when → Do NOT use when → Commands).

Issues Found

suggestion — Line 490: Copy-paste error in query history description

src/server/templates/skill/SKILL.md:490

**View query history:** to check past curations   ← wrong word

The description says "to check past curations" but this is the query history section. Should read "to check past queries". An inline suggestion has been posted on this line.


Positives

  • Consistent structure: Section 11 matches sections 8–10 exactly (Overview, Use/Do-NOT-use, command blocks). Easy for agents to parse reliably.
  • Cross-references are correct: The Do-NOT-use block correctly redirects to brv query and brv curate for new operations.
  • logId format documented: cur-1739700001000 / qry-1739700001000 patterns are documented inline — helpful for agents that need to reference a specific log entry.
  • No scope creep: Documentation-only, no CLI behavior or code touched.

One minor fix needed (the copy-paste error on line 490) before merge.

Comment thread src/server/templates/skill/SKILL.md Outdated
brv curate view --help
```

**View query history:** to check past curations
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Copy-paste error — the description says "to check past curations" but this is the query history section, not curate. Should match the analogous label used for curate history.

Suggested change
**View query history:** to check past curations
**View query history:** to check past queries

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 18, 2026

Claude finished @DatPham-6996's task in 1m 12s —— View job


PR Review: feat/ENG-2136 — Add section 11 for query and curate history

  • Gather context and read changed files
  • Check if previous copy-paste fix was applied
  • Verify new brv query-log summary block against implementation
  • Post updated review

Summary

Score: 5/5 — All issues from the previous review have been resolved. The new commit also adds a well-structured brv query-log summary block that accurately reflects the implementation.

What changed since last review

Previous issue fixed: src/server/templates/skill/SKILL.md:491

**View query history:** to check past curations**View query history:** to check past queries

New content added (commit 815f399): A brv query-log summary block documenting --last, --since, --before, and --format narrative — all flags verified against src/oclif/commands/query-log/summary.ts. Accurate and consistent with the implementation.

Bonus fix included (not called out in previous review)

The old section 3 had a subtly broken command:

brv curate view detail   # ← missing --

Section 11 correctly uses:

brv curate view --detail  # ✅ matches Flags.boolean in view.ts

Positives

  • All flags verified correct--detail, --limit, --tier, --last, --since, --before, --format all exist in their respective command implementations.
  • --limit 1000 addition — curate view in section 11 adds --limit 1000 to the filter example, which was missing from the old section 3 block.
  • Tier filter explanation — resolution tier levels (0–4) are documented inline with a human-readable description, genuinely useful for agents.
  • Consistent section structure — matches sections 8–10 exactly.

This PR is ready to merge.

Copy link
Copy Markdown
Collaborator

@bao-byterover bao-byterover left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 20, 2026

Claude finished @DatPham-6996's task in 1m 17s —— View job


PR Review: feat/ENG-2136 — Add section 11 for query and curate history

  • Gather context and read changed files
  • Analyze diff and verify previous fixes
  • Post review with score

Summary

Score: 5/5 — All prior review issues resolved; content verified accurate against implementation.

Verification

All flags and examples in section 11 were checked against their CLI implementations:

brv curate view (src/oclif/commands/curate/view.ts):

  • --detailFlags.boolean
  • --since, --before, --status, --limit ✅ all present

brv query-log view (src/oclif/commands/query-log/view.ts):

  • --detail, --since, --before, --status, --limit, --tier ✅ all present

brv query-log summary (src/oclif/commands/query-log/summary.ts):

  • --last, --since, --before, --format narrative ✅ all present

Tier descriptions (src/server/core/domain/entities/query-log-entry.ts):

  • 0=exact cache, 1=fuzzy cache, 2=direct search, 3=optimized LLM, 4=full agentic ✅ all match named constants

Positives

  • Previous issues resolved: copy-paste error ("past curations""past queries") and broken view detailview --detail are both fixed.
  • Consistent structure: section 11 matches sections 8–10 exactly (Overview → Use when → Do NOT use when → command blocks).
  • Accurate cross-references: Do-NOT-use block correctly redirects to brv query and brv curate for new operations.
  • Tier levels documented inline: resolution tier descriptions are accurate and genuinely useful for agents choosing filter values.
  • No scope creep: documentation-only, no CLI code touched.

This PR is ready to merge.

@bao-byterover bao-byterover merged commit 4859ef3 into main Apr 20, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants