Skip to content

Release/3.8.3#535

Merged
bao-byterover merged 5 commits intomainfrom
release/3.8.3
Apr 23, 2026
Merged

Release/3.8.3#535
bao-byterover merged 5 commits intomainfrom
release/3.8.3

Conversation

@bao-byterover
Copy link
Copy Markdown
Collaborator

No description provided.

@bao-byterover bao-byterover requested a review from leehpham as a code owner April 23, 2026 04:24
@bao-byterover bao-byterover merged commit d8ea00d into main Apr 23, 2026
7 checks passed
@bao-byterover bao-byterover deleted the release/3.8.3 branch April 23, 2026 04:24
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 23, 2026

Claude finished @bao-byterover's task in 2m 18s —— View job


PR Review: Release/3.8.3

  • Gather context and read changed files
  • Review CHANGELOG.md changes
  • Review CLAUDE.md changes
  • Review CONTRIBUTING.md changes
  • Review README.md changes
  • Review package.json changes
  • Post inline comments for specific issues
  • Post overall summary

Summary

Score: 4 / 5

This is a clean documentation-only release PR bumping the version from 3.8.2 to 3.8.3. No source code changes — only CHANGELOG.md, CLAUDE.md, CONTRIBUTING.md, README.md, and package.json (version bump). The documentation is well-written and the changelog entries are user-facing and descriptive. A few minor issues:

Bugs / Issues

  • README.md lines 118–119 — duplicate bullet point (inline comment posted): "Multi-machine access" appears twice in the ByteRover Cloud feature list. The second entry (sync your context tree across devices) is a shorter, less informative duplicate of the first (sync your context tree across devices with cloud backup). One should be removed. Fix this →

Nitpicks

  • CHANGELOG.md line 8 — double "in" (inline comment posted): "sign in in your browser" → "sign in with your browser".

  • README.md vs CLAUDE.md — provider count mismatch: README (lines 37 & 223) says "18 LLM providers"; CLAUDE.md says "20 providers in infra/llm/providers/". One is stale. Fix this →

  • Commit message typo: The squashed commit includes the message "Bump veversion to 3.8.3" (double "ve"). No impact on the release, but worth noting.

What looks good

  • CHANGELOG entries are user-facing and actionable — each entry explains the old behaviour and what changed.
  • CLAUDE.md correctly documents the new brv login OAuth-first default added in this release.
  • CONTRIBUTING.md additions are thorough: branch naming conventions, git hooks, web UI dev workflow, project structure, and the TDD steps mirror the existing development standards.
  • package.json version bump is the only code change, as expected for a patch release.

Comment thread README.md
- 🔄 **Team context sync** — push and pull shared knowledge across teammates
- 📂 **Shared spaces** — organize context across multiple projects and teams
- 💻 **Multi-machine access** — sync your context tree across devices with cloud backup
- 💻 **Multi-machine access** — sync your context tree across devices
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue (duplication): Duplicate bullet — lines 118 and 119 both describe "Multi-machine access". The second entry appears to be a copy-paste leftover with slightly less detail.

Remove line 119 — line 118 (sync your context tree across devices with cloud backup) covers this point fully.

Comment thread CHANGELOG.md
## [3.8.3]

### Changed
- **`brv login` opens your browser by default** — Just run `brv login` and sign in in your browser. On CI or a remote shell, use `--api-key <key>` instead (get one at https://app.byterover.dev/settings/keys). SSH and non-interactive shells are detected automatically and skip the browser step.
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick (grammar): "sign in in your browser" — double "in". Should be "sign in with your browser" or "sign in using your browser".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant