merge: sync main (3.10.1) into curation-enhancement#599
Conversation
Resolves three conflicts created by the overlap of ENG-2485 (defer summary cascade to dream, on this branch) and ENG-2522 (detach post-curate Phase 4, shipped on main, PR #582). The two changes touch the same lines but address different costs — LLM cost vs user-visible latency — and compose cleanly. curate-executor.ts - Adopt main's {finalize, response} architecture so the daemon fires task:completed before Phase 4 runs. - Inside finalize, keep cascade-defer: snapshot diff → enqueueStaleSummaryPaths + buildManifest. Drop main's propagateSummariesUnderLock — the dream lock existed to coordinate inline _index.md writes, which cascade-defer eliminates from curate. - Preserve all exp 03 (cache_control) and exp 04 (recon pre-pipelining) changes in Phases 1-3. - Extract propagateAndRebuild private helper alongside main's incrementDreamCounter. dream-executor.ts - Keep this branch's runStaleSummaryPropagation extracted seam (main did not change dream-executor; nothing lost). curate-executor.test.ts - Rewrite runAgentBody/finalize split assertions to expect cascade-defer (enqueueStaleSummaryPaths + buildManifest) instead of propagateStaleness. - Drop the dream-lock coordination describe block — the lock is no longer taken in curate's Phase 4 (folder-pack still uses it). folder-pack-executor still calls propagateSummariesUnderLock; the helper file stays. Verified: typecheck, lint (0 errors on resolved files), 7284 tests pass.
|
Claude finished @danhdoan's task in 4m 22s —— View job PR Review — sync main (3.10.1) into curation-enhancement
Overall Score: 4 / 5This is a well-executed sync that brings substantial, production-quality features into the branch. The implementation quality is high across the board. What's new (summary of additions)
Strengths
Issues raised (inline comments)
None of these are blockers. Issues 1 and 2 are straightforward fixes; 3 and 4 are quality-of-life suggestions. |
ncnthien
left a comment
There was a problem hiding this comment.
look very good, so nice man
Summary
User-visible changes
N/A
Evidence
N/A
Checklist
npm test)npm run lint)npm run typecheck)npm run build)mainRisks and mitigations
None