Skip to content

Releease/3.12.0#624

Merged
bao-byterover merged 3 commits into
mainfrom
releease/3.12.0
May 9, 2026
Merged

Releease/3.12.0#624
bao-byterover merged 3 commits into
mainfrom
releease/3.12.0

Conversation

@bao-byterover
Copy link
Copy Markdown
Collaborator

No description provided.

@bao-byterover bao-byterover requested a review from leehpham as a code owner May 9, 2026 08:17
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2026

Claude finished @bao-byterover's task in 2m 50s —— View job


PR Review: 3.12.0 release prep

Overall score: 4 / 5 — clean release-prep PR. Version, changelog, and docs are mutually consistent and the doc claims I spot-checked against the codebase all hold up. Minor stylistic nits, no blockers.

Scope

Pure release-prep: bumps package.json to 3.12.0, adds the ## [3.12.0] section to CHANGELOG.md, and refreshes CLAUDE.md (new npm scripts, new agent/infra and server/infra modules, LLM provider count 21 → 20, new "Other oclif topic groups" section, vc remote add|remove|set-url subcommands). No source code changes — risk is limited to documentation drift.

Verification (spot checks against HEAD)

  • package.json 3.11.0 → 3.12.0 matches the new CHANGELOG heading.
  • ✅ All four newly documented npm scripts (dev:kill, lint:fix, build:ui:submodule, dev:ui:package) exist in package.json.
  • src/agent/infra/sandbox and src/agent/infra/session exist (newly listed).
  • src/server/infra/connectors and src/server/infra/session exist (newly listed).
  • ✅ LLM provider count: src/agent/infra/llm/providers/ contains 22 entries; subtracting index.ts and types.ts leaves 20 providers — the 21 → 20 change is accurate.
  • ✅ New oclif subcommand surface area (hub install/list/registry add|list|remove, space list/switch, connectors install/list, model list/switch, providers connect/disconnect/list/switch, curate view) all match the actual command tree under src/oclif/commands/.
  • brv vc remote add|remove|set-url exists at src/oclif/commands/vc/remote/.

Inline comments posted

  • CHANGELOG.md:5suggestion: add ISO date to the ## [3.12.0] heading per Keep-a-Changelog convention.
  • CLAUDE.md:64–67nitpick: mixed module-count style — agent/ and server/ lines drop their counts, but the adjacent tui/ line still hardcodes (23 modules, ...). Pick one style.
  • CLAUDE.md:112–119suggestion: rename the "Other oclif topic groups" header — reads as a residual bucket; "Additional oclif topics" / "oclif topic subcommands" frames the section more deliberately.
  • package.json:15praise: version, changelog, and doc updates are mutually consistent — clean release-prep.

Other observations (not worth their own inline)

  • Branch / commit-message typos. Branch is releease/3.12.0 (three e's), and commit c8fabf4 is chore: Bump veversion to 3.12.0. These don't affect the published artifact, but the branch name will linger in the merge commit / PR history. Worth fixing typos in future release branches.
  • CHANGELOG accuracy. All four bullets describe behavior I can locate in the tree:
    • Tasks history page: src/webui/pages/tasks-page.tsx + src/webui/features/tasks/.
    • Dream synthesize/consolidate: src/server/infra/dream/operations/.
    • brv push related cleanup and security update: traceable to PR feat: [ENG-2721] patch npm high severity #623 (feat: [ENG-2721] patch npm high severity) which is the immediate parent commit.

Recommendation

Approve for merge after addressing (or consciously deferring) the three doc nits. None are blocking — the release artifact is correct and the docs accurately reflect the new shipping surface.
· Branch: releease/3.12.0

Comment thread CHANGELOG.md

All notable user-facing changes to ByteRover CLI will be documented in this file.

## [3.12.0]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (non-blocking): Keep a Changelog convention recommends an ISO date next to the version header so readers can see when a release shipped without cross-referencing git tags. The earlier entries in this file follow the same pattern.

Suggested change
## [3.12.0]
## [3.12.0] - 2026-05-09

Comment thread CLAUDE.md
Comment on lines +64 to 67
- `agent/` — LLM agent: `core/` (interfaces/domain), `infra/` (modules including llm, memory, map, swarm, sandbox, session, tools, document-parser), `resources/` (prompts YAML, tool `.txt` descriptions)
- `server/` — Daemon infrastructure: `config/`, `core/` (domain/interfaces), `infra/` (modules including vc, git, hub, mcp, cogit, connectors, project, provider-oauth, session, space, dream, webui), `templates/`, `utils/`
- `shared/` — Cross-module: constants, types, transport events, utils
- `tui/` — React/Ink TUI: app (router/pages), components, features (23 modules, including vc, worktree, source, hub, curate), hooks, lib, providers, stores
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpick (non-blocking): Inconsistent module-count style within this section. agent/ and server/ were just changed from (23 modules, including ...) / (31 modules, including ...) to (modules including ...) (dropping counts to avoid drift), but the tui/ line two rows down still hardcodes features (23 modules, ...). Either drop all counts or keep them all up-to-date — mixed style in adjacent bullets is confusing for readers and for future agents reading these as ground truth.

For reference, current actuals:

  • src/agent/infra/ — 23 entries
  • src/server/infra/ — 31 entries
  • src/tui/features/ — 23 entries

Comment thread CLAUDE.md
Comment on lines +112 to +119
### Other oclif topic groups

- `brv hub install | list | registry (add|list|remove)` — Context Hub (npm-style package manager for context); registry config is per-project
- `brv space list | switch` — Context Hub spaces (team/space scoping)
- `brv connectors install | list` — agent-side connector plugins (e.g., OpenClaude registered as a connector)
- `brv model list | switch` — pick the LLM model for the active provider
- `brv providers connect | disconnect | list | switch` — provider OAuth / API-key management
- `brv curate view` — read-only inspect of a curate operation; the main curate entry is the REPL slash command
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (non-blocking): The header "Other oclif topic groups" reads as a leftover bucket. The existing Source Layout bullet at line 69 already enumerates these topic groups (hub/, space/, connectors/, model/, providers/, curate/, ...) — what's actually new here is the per-topic subcommand surface. Consider renaming to something like ### oclif topic subcommands or ### Additional oclif topics so it reads as a deliberate addition rather than a residual.

Also worth noting: swarm and query-log topic groups already have dedicated detail elsewhere in this file (Swarm section / VC,Worktrees section respectively), so the asymmetry is fine — no action needed there.

@bao-byterover bao-byterover merged commit e4c3b95 into main May 9, 2026
10 checks passed
Comment thread package.json
"knowledge-management"
],
"version": "3.11.0",
"version": "3.12.0",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: Version bump matches the new ## [3.12.0] heading in CHANGELOG.md and the doc updates in CLAUDE.md — consistent across the three files. Also, since the version is bumped in the same PR as CHANGELOG.md, when this merges to main the published 3.12.0 release will ship with its release notes already in place.

@bao-byterover bao-byterover deleted the releease/3.12.0 branch May 18, 2026 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant