fix: redact sensitive data in MCP resource endpoints#295
Merged
RyanNg1403 merged 1 commit intomainfrom Mar 16, 2026
Merged
Conversation
- Apply redactSensitiveData() to agent card resource to mask any sensitive fields (apiKey, token, secret, etc.) before serialization - Replace raw error messages in failed MCP connections with generic "Connection failed" to prevent leaking API keys, URLs, or credentials - Stop exposing raw error details in stats error handler - Fix pre-existing prettier formatting in neo4j.ts Fixes #292
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
redactSensitiveData()tocipher://agent/cardresource to mask sensitive fields before serializationcipher://agent/statsfailed connections with generic "Connection failed" — prevents leaking API keys, URLs, or credentials via error stringsUses the existing
redactSensitiveData()utility fromsrc/app/api/utils/security.ts, already used by the REST API/api/configroute.Test plan
pnpm run format:checkpassesFixes #292