Skip to content

Conversation

@lanseg
Copy link
Collaborator

@lanseg lanseg commented Nov 28, 2025

Screenshot 2025-11-27 at 15-24-34 Extract – Détails de la demande 12 - Test request 2 _ MO - Cadastre complet

Purpose: per-request user ownership, make it possible for one operator to make a single request visible to another operator, even if the second operator is not an owner of the parent process.

Behavior:

  1. Admin user sees all requests, no matter what users or groups are configured for the request or process
  2. User can see or modify request if any of this applies:
    1. User or user's group is added to a Request
    2. User or user's group is added to a parent Process of this request
  3. A request-owning User can modify request-owning users and groups.
  4. After the user removes themselves from the request owners list, per-process ownership rules apply.

@lanseg lanseg marked this pull request as ready for review November 28, 2025 16:34
@lanseg lanseg marked this pull request as draft November 28, 2025 16:35
@lanseg lanseg marked this pull request as ready for review November 30, 2025 11:26
@lanseg lanseg requested a review from maltaesousa December 1, 2025 09:03
@maltaesousa
Copy link
Collaborator

That's a great addition, thanks!

Copy link
Collaborator

@maltaesousa maltaesousa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lanseg I'm approving this but I didn't review the code, I've no experience in Java :(

Could you add the new tables to a SQL file, please? The project doesn't have migrations mechanism, we run sql files to existing databases when we upgrade and I think this new functionality will be merged later into asit :)
If you don't have time to do it, tell me and I can have a look at it.

@lanseg
Copy link
Collaborator Author

lanseg commented Dec 1, 2025

@lanseg I'm approving this but I didn't review the code, I've no experience in Java :(

Could you add the new tables to a SQL file, please? The project doesn't have migrations mechanism, we run sql files to existing databases when we upgrade and I think this new functionality will be merged later into asit :) If you don't have time to do it, tell me and I can have a look at it.

Added key migrations, similar to the exising ones.
For me tables and keys were created automatically, by spring/hibernate itself, so there should be no problem with migration.

@lanseg lanseg merged commit 9dd8241 into master Dec 1, 2025
@lanseg lanseg deleted the GSGGR-581-from-master branch December 1, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants