Repository navigation
Vouch request: three pending PRs predating the vouch policy (#2706, #2725, #2735) #4057
Replies: 2 comments
|
Quick update: all three PRs referenced above (#2706, #2725, #2735) were just closed as part of a general "PRs open >2 weeks" cleanup sweep — the closing comment on each was explicit that this isn't a judgment on the change itself. Since I'm not yet vouched, I'd rather not reopen them or open fresh PRs while this request is still pending, in case that reads as trying to route around the process. Once a maintainer has a chance to vouch, happy to go whichever way is preferred — reopening the existing three (keeps review history intact) or opening fresh PRs against current |
|
!vouch @Mathews-Tom Sorry for the trouble, there's just too much in the queue 😓 |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Context
I have three open PRs, all opened 2026-06-15/16, before the vouch-manage workflow and CONTRIBUTING.md policy landed on 2026-06-19. All three are still OPEN with a CLEAN merge state. I also have prior merged history in this repo from before the policy: #1942 ("Add /review PR URL support", closes #1743), merged 2026-06-15.
Filing one combined request rather than three separate discussions since a vouch applies to the author, not a specific PR.
#2706 — add Claude Code rules discovery
Fixes #2613. Loads Claude Code rules from
~/.claude/rules/**/*.{md,mdc}and project.claude/rules/**/*.{md,mdc}through the standard rules capability; project rules win on name collision. Always-on, no new setting, matching every other.claude/*loader (maintainer-confirmed direction).Touches
src/discovery/claude.tssrc/discovery/helpers.tssrc/capability/rule.tssrc/internal-urls/*src/system-prompt.tsVerification
bun test packages/coding-agent/test/discovery/claude-rules.test.ts packages/coding-agent/test/discovery/claude-commands.test.tsbun --cwd=packages/coding-agent run check.#2725 — add error turn notifications
Fixes #2691. Independent
error.notifysetting (defaulton) emitting a distinct notification when a turn ends withstopReason === "error", while aborted turns stay quiet andcompletion.notifyis untouched.Touches
src/config/settings-schema.tssrc/modes/controllers/event-controller.tsVerification
bun test packages/coding-agent/test/modes/controllers/event-controller-abort-guard.test.tsbun --cwd=packages/coding-agent run check.#2735 — add friendly names to secret placeholders
Fixes #2465. Optional
friendlyNamemetadata onSecretEntryso obfuscated placeholders carry safe semantic context (e.g.#GITHUBTOKEN_AB12:L#), content-derived stable hash bases, and:U/:L/:C/:Mcase hints — direction confirmed across the issue discussion.Touches
src/secrets/obfuscator.tssrc/secrets/index.tsdocs/secrets.mdVerification
bun test packages/coding-agent/test/secrets-obfuscator.test.ts packages/coding-agent/test/agent-session-silent-abort.test.tsbun --cwd=packages/coding-agent run check.Could a maintainer vouch me so these three can proceed through review under the current policy? Happy to address feedback on any of them.
All reactions