Repository navigation
Vouch request: fix for #4187 (post-rewind context invites a second rewind call) #4189
Closed
tjboudreaux
started this conversation in
General
Replies: 1 comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Hi — asking to be vouched per CONTRIBUTING.md so I can open a PR for a fix I have ready.
What I'd like to contribute
Fix for #4187 (post-rewind context invites a second
rewindcall, which then fails with an unactionableNo active checkpoint.).The branch is ready on my fork:
tjboudreaux:fix/rewind-report-checkpoint-closed(diff vs main).Summary of the change (details in the issue):
rewind-reportcustom message with a checkpoint-complete notice (newprompts/system/rewind-report-context.md) so the post-rewind turn knows the checkpoint is CLOSED and doesn't re-callrewind.rewinderror self-recovering (tells the model to continue, not retry).prompts/tools/rewind.md.agent-session-checkpoint-rewind-branch.test.ts, aRewindToolerror-contract test, and a containment fix incheckpoint-rpc-qa.ts.test/task/worktree.test.tsthat was breakingbun checkon main (pre-existing; happy to split it out if you'd rather).bun checkpasses (ts + rs),bun test test/agent-session-checkpoint-rewind-branch.test.tspasses (2 pass / 14 expects), changelog updated under[Unreleased]→ Fixed.I also added independent evidence to #4173 (the replay-side hardening) from a captured 400 session — this fix addresses the context shape that manufactured the wasted
rewindcall in that same session.If vouched, I'll open the PR immediately. Thanks!
All reactions