Refactor Pathfinding Utility

[candour]

I have refactored the Pathfinding.kt utility to be more idiomatic and readable while maintaining its efficiency. Key changes include using generateSequence for path reconstruction and simplifying the PriorityQueue management with compareBy. All existing pathfinding and game logic tests passed successfully.

---

PR created automatically by Jules for task 14471854209252752414 started by @candour

Summary by CodeRabbit

• Internal Optimizations
  • Pathfinding system refactored for improved performance and efficiency. All existing pathfinding functionality and behavior remain unchanged.

[google-labs-jules]

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.

---

For security, I will only act on instructions from the user who triggered this task.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: f0e39486-6183-4505-bd62-fad47ddb5c00

📥 Commits

Reviewing files that changed from the base of the PR and between 540c22c and f3437e3.

📒 Files selected for processing (1)

• app/src/main/java/com/messark/hawker/utils/Pathfinding.kt

---

📝 Walkthrough

Walkthrough

The Pathfinding.findPath A* pathfinding algorithm is refactored to change its internal data structures and path reconstruction mechanism. The priority queue element type changes from ScoredCoordinate to a new internal Node class, the algorithm adopts a closed-set-based approach allowing duplicate queue entries, and path reconstruction uses direct sequence generation from parent links instead of a separate helper function.

Changes

A Algorithm Refactoring*

Layer / File(s)	Summary
Data Structures & Imports app/src/main/java/com/messark/hawker/utils/Pathfinding.kt (lines 5–16, 64–67)	Add kotlin.math.abs import; define private Node(fScore, coordinate) class for priority queue elements; update internal maps to use gScores, parents, and closedSet.
Core A Algorithm* app/src/main/java/com/messark/hawker/utils/Pathfinding.kt (lines 17–63)	Refactor findPath to permit duplicate queue entries and use closedSet to process each coordinate once; build path directly from parents map via generateSequence(end) { parents[it] }.toList().reversed() when end is reached.
Heuristic Function app/src/main/java/com/messark/hawker/utils/Pathfinding.kt (lines 64–67)	Update heuristic to use kotlin.math.abs instead of Math.abs for integer axial-distance calculation.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• candour/towerpower#118: Refactors the same Pathfinding.findPath function in the opposite direction (removes internal Node class and introduces ScoredCoordinate with reconstructPath helper).

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'Refactor Pathfinding Utility' accurately reflects the main change: a refactoring of the Pathfinding.kt utility to improve idiomaticity and readability while maintaining performance.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch refactor-pathfinding-14471854209252752414

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

Build Successful! 🚀

Download APK

Note: This link will be removed when the PR is closed.