Skip to content

Fix Tower Range Indicator Proportions#73

Merged
candour merged 1 commit into
mainfrom
fix-range-indicator-11149041854887172118
Apr 23, 2026
Merged

Fix Tower Range Indicator Proportions#73
candour merged 1 commit into
mainfrom
fix-range-indicator-11149041854887172118

Conversation

@candour
Copy link
Copy Markdown
Owner

@candour candour commented Apr 23, 2026

Fixed the confusing range indicator by replacing the standard circle with an ellipse that correctly reflects the hexagonal grid's aspect ratio. The vertical radius now accounts for the rowSpacingFactor (0.69f) used in the axial-to-screen coordinate mapping. Additionally, the radius was adjusted to pass halfway between the centers and outer edges of hexes at the limit of the tower's reach, providing a more intuitive visual representation of the attack area.


PR created automatically by Jules for task 11149041854887172118 started by @candour

Summary by CodeRabbit

  • Bug Fixes
    • Updated stall range visualization to display as ovals instead of circles for improved spatial accuracy on the game board.

…roportions

- Replaced circular range indicator with an elliptical one (`drawOval`).
- Calculated ellipse radii to account for vertical "squashing" of the hexagonal grid.
- Set range indicator reach to be halfway between the center and outer edge of the furthest reachable hex.
- Verified indicator is only displayed for selected board stalls.

Co-authored-by: candour <4670475+candour@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 23, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 412a9025-07c0-49bb-aa44-2a1c44ba34a7

📥 Commits

Reviewing files that changed from the base of the PR and between 8c60ab9 and 338e83d.

📒 Files selected for processing (1)
  • app/src/main/java/com/messark/hawker/ui/components/GameBoard.kt

📝 Walkthrough

Walkthrough

The range visualization for selected stalls in the GameBoard component has been modified to use ovals instead of circles. The horizontal and vertical radii are now calculated separately, with the vertical radius applying a row spacing factor and both axes receiving a 0.25f padding offset.

Changes

Cohort / File(s) Summary
Range Visualization Update
app/src/main/java/com/messark/hawker/ui/components/GameBoard.kt
Changed stall range display from concentric circles with single radius to concentric ovals with separate radiusX (from stall.range) and radiusY (from stall.range × rowSpacingFactor) plus 0.25f padding. Drawing method updated from drawCircle() to drawOval(), preserving layered colors and stroke widths.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'Fix Tower Range Indicator Proportions' directly and concisely describes the main change: converting the tower range indicator from circles to ellipses that properly account for the hexagonal grid's aspect ratio.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix-range-indicator-11149041854887172118

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown

Build Successful! 🚀

Download APK

Note: This link will be removed when the PR is closed.

@candour candour merged commit b3f9695 into main Apr 23, 2026
3 checks passed
@candour candour deleted the fix-range-indicator-11149041854887172118 branch April 23, 2026 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant