Fix broken source links #221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Retrieve the actual closest package to docObjects that had their parent's name set to some name higher up in the family tree for visual purposes. Resolves #204
rlin415
commented
Mar 31, 2017
|
|
||
| var splittedName = current.name.split('/'); | ||
| var hasSlash = splittedName.length > 1; | ||
| var hasSlash = splitName.length > 1; |
Contributor
Author
There was a problem hiding this comment.
@chasenlehara I think this will cause problems. You defined splitName on line 184, but we are using it here.
Member
There was a problem hiding this comment.
Ugh sorry, you’re right, I’ll fix it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retrieve the actual closest package to docObjects that had their
parent's name set to some name higher up in the family tree.
Resolves #204