report: Collect open file descriptors in crash reports#555
Closed
basil wants to merge 1 commit intocanonical:mainfrom
Closed
report: Collect open file descriptors in crash reports#555basil wants to merge 1 commit intocanonical:mainfrom
basil wants to merge 1 commit intocanonical:mainfrom
Conversation
546108d to
4a498c9
Compare
Contributor
Author
|
CLA checks, linter, and |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #555 +/- ##
==========================================
+ Coverage 84.40% 84.41% +0.01%
==========================================
Files 104 104
Lines 20848 20901 +53
Branches 3259 3265 +6
==========================================
+ Hits 17597 17644 +47
- Misses 2813 2818 +5
- Partials 438 439 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bdrung
reviewed
Mar 24, 2026
Read /proc/pid/fd and /proc/pid/fdinfo to populate a new OpenFds field with each file descriptor's target path and metadata. Also map COREDUMP_OPEN_FDS from systemd-coredump into the same field.
bdrung
approved these changes
Mar 25, 2026
Member
|
Merged (added bug reference and signed commit) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
systemd-coredump(8)provides information about open file descriptors viaCOREDUMP_OPEN_FDSin the following format:The first line contains the file descriptor number
fdand the path, while subsequent lines show the contents of/proc/pid/fdinfo/fd. This can be very useful during postmortem debugging.This PR implements the same feature for Apport. We read
/proc/pid/fdand/proc/pid/fdinfoto populate a newOpenFdsfield with each file descriptor's target path and metadata. We also mapCOREDUMP_OPEN_FDSfromsystemd-coredump(8)into the same field.Unit and integration tests have been updated to cover the new functionality, as well as the specification in
doc/data-format.tex.Fixes 2143109
CC @bdrung