Skip to content

ci: use environment variables for dependencies#617

Merged
bdrung merged 2 commits intocanonical:mainfrom
bdrung:reuse-dependencies
Apr 29, 2026
Merged

ci: use environment variables for dependencies#617
bdrung merged 2 commits intocanonical:mainfrom
bdrung:reuse-dependencies

Conversation

@bdrung
Copy link
Copy Markdown
Member

@bdrung bdrung commented Apr 29, 2026

Avoid duplicating the list of packages to install by introducing environment variables.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.54%. Comparing base (c21b7c6) to head (c6506e9).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #617      +/-   ##
==========================================
- Coverage   84.54%   84.54%   -0.01%     
==========================================
  Files         104      104              
  Lines       21028    21026       -2     
  Branches     3221     3219       -2     
==========================================
- Hits        17779    17777       -2     
+ Misses       2809     2808       -1     
- Partials      440      441       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bdrung bdrung force-pushed the reuse-dependencies branch from daddec2 to 1ecaedd Compare April 29, 2026 14:20
Copy link
Copy Markdown
Contributor

@Hyask Hyask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A most welcome change!

bdrung added 2 commits April 29, 2026 17:29
Install `xterm` in the `system-installed` CI test and remove support
skipping `test_ui_run_terminal` (to not regress in code coverage by the
following commit).
Avoid duplicating the list of packages to install by introducing
environment variables.
@bdrung bdrung force-pushed the reuse-dependencies branch from 1ecaedd to c6506e9 Compare April 29, 2026 15:29
@bdrung
Copy link
Copy Markdown
Member Author

bdrung commented Apr 29, 2026

Just rebased.

@bdrung bdrung merged commit c6506e9 into canonical:main Apr 29, 2026
19 checks passed
@bdrung bdrung deleted the reuse-dependencies branch April 29, 2026 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants