Skip to content

Add arm64, ppc64el and s390x and migrate workflows to charm-ci#99

Merged
weiiwang01 merged 19 commits into
mainfrom
charm-ci
Jun 30, 2026
Merged

Add arm64, ppc64el and s390x and migrate workflows to charm-ci#99
weiiwang01 merged 19 commits into
mainfrom
charm-ci

Conversation

@weiiwang01

@weiiwang01 weiiwang01 commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

What this PR does

Add arm64, ppc64el and s390x and migrate workflows to charm-ci.

Why we need it

Fix: #97

Migrating workflows to charm-ci is required for the multi-arch build.

Checklist

  • I followed the contributing guide
  • I added or updated the documentation (if applicable)
  • I updated docs/changelog.md with user-relevant changes
  • I used AI to assist with preparing this PR
  • I added or updated tests as needed (unit and integration)
  • If integration test modules are used: I updated the workflow configuration
    (e.g., in .github/workflows/integration_tests.yaml, ensure the modules list is correct)
  • If this is a Grafana dashboard: I added a screenshot of the dashboard
  • If this is Terraform: terraform fmt passes and tflint reports no errors
  • If this is Rockcraft: I updated the version

@weiiwang01 weiiwang01 marked this pull request as ready for review June 25, 2026 07:36
@weiiwang01 weiiwang01 requested a review from a team as a code owner June 25, 2026 07:36
Comment thread .github/workflows/integration_test.yaml Outdated
Comment thread tests/integration/conftest.py
Comment thread .github/workflows/integration_test.yaml

@florentianayuwono florentianayuwono left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did this run the tests for 20.04 and 22.04? somehow i couldn't see the checks for these bases (only 24.04 is present)

@weiiwang01

Copy link
Copy Markdown
Contributor Author

did this run the tests for 20.04 and 22.04? somehow i couldn't see the checks for these bases (only 24.04 is present)

Yes, the 24.04 in the test name (for example, integration-test / integration-test-ci:ubuntu-24.04-arm64:build/tests/integration/run:focal) refers to the test runner name. And the base variant is at the end of the name (focal). You can see this test is running with the base 20.04 in the test argument.

https://github.com/canonical/aproxy-operator/actions/runs/28387227288/job/84105129726#step:11:1150

@florentianayuwono florentianayuwono left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks weii!

@weiiwang01 weiiwang01 enabled auto-merge (squash) June 30, 2026 06:35
@weiiwang01 weiiwang01 merged commit 2663b43 into main Jun 30, 2026
57 of 68 checks passed
@weiiwang01 weiiwang01 deleted the charm-ci branch June 30, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Charm fails to deploy against non-amd64 units

3 participants