pam: show password prompt directly on TTY if possible#1269
Closed
shiv-tyagi wants to merge 1 commit intocanonical:mainfrom
Closed
pam: show password prompt directly on TTY if possible#1269shiv-tyagi wants to merge 1 commit intocanonical:mainfrom
shiv-tyagi wants to merge 1 commit intocanonical:mainfrom
Conversation
Signed-off-by: Shiv Tyagi <shivtyagi3015@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1269 +/- ##
==========================================
+ Coverage 85.00% 85.68% +0.67%
==========================================
Files 119 99 -20
Lines 7669 6685 -984
Branches 111 111
==========================================
- Hits 6519 5728 -791
+ Misses 1094 901 -193
Partials 56 56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
I've another branch ready for this for a while, but I had to delay it for preparing tests, so thanks a lot for your contribution but I'm handling this already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1230
This makes PAM to write authentication prompt while executing sudo directly to tty in order to make sure it is visible even if stdout/stderr are redirected.
Verified locally, it is working as expected.