Skip to content

e2e-tests: Allow login to VM as root with empty password in CI#1384

Merged
adombeck merged 6 commits intomainfrom
UDENG-9610-no-ssh-secrets
Apr 6, 2026
Merged

e2e-tests: Allow login to VM as root with empty password in CI#1384
adombeck merged 6 commits intomainfrom
UDENG-9610-no-ssh-secrets

Conversation

@adombeck
Copy link
Copy Markdown
Contributor

@adombeck adombeck commented Apr 2, 2026

Avoids the need to provide an SSH secret key via GitHub secrets, which are not available in dependabot PRs and PRs by external users.

When provisioning the e2e-runner VM locally, we still require an SSH public key.

Closes #1278
UDENG-9610

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.38%. Comparing base (7624c01) to head (ac789a9).
⚠️ Report is 28 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1384      +/-   ##
==========================================
+ Coverage   86.32%   86.38%   +0.05%     
==========================================
  Files          99       99              
  Lines        6690     6690              
  Branches      111      111              
==========================================
+ Hits         5775     5779       +4     
+ Misses        859      855       -4     
  Partials       56       56              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@adombeck adombeck force-pushed the UDENG-9610-no-ssh-secrets branch from 3ecbaca to 1262c38 Compare April 2, 2026 18:45
adombeck added 6 commits April 2, 2026 21:50
Preparation for allowing login as root without password in CI.
ssh.sh now logs in as root, so we don't need sudo anymore.
These commands are executed as root so we don't need to use sudo.
Automatic changes made by my IDE.
Avoids the need to provide an SSH secret key via GitHub secrets, which
are not available in dependabot PRs and PRs by external users.

When provisioning the e2e-runner VM locally, we still require an SSH
public key.
@adombeck adombeck force-pushed the UDENG-9610-no-ssh-secrets branch from 1262c38 to ac789a9 Compare April 2, 2026 19:50
@adombeck adombeck marked this pull request as ready for review April 2, 2026 20:57
@adombeck adombeck requested a review from denisonbarbosa April 2, 2026 20:57
@adombeck adombeck merged commit 65c72c5 into main Apr 6, 2026
25 of 32 checks passed
@adombeck adombeck deleted the UDENG-9610-no-ssh-secrets branch April 6, 2026 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix e2e-tests failing in dependabot PRs due to missing SSH secrets

2 participants