Skip to content

docs: update ssh configuration key to match broker.conf files#1427

Merged
nooreldeenmansour merged 2 commits intomainfrom
docs-update-ssh-property
Apr 14, 2026
Merged

docs: update ssh configuration key to match broker.conf files#1427
nooreldeenmansour merged 2 commits intomainfrom
docs-update-ssh-property

Conversation

@nooreldeenmansour
Copy link
Copy Markdown
Member

@nooreldeenmansour nooreldeenmansour commented Apr 10, 2026

Update the ssh property in the docs to match broker.conf files

ssh_allowed_suffixes -> ssh_allowed_suffixes_first_auth

Should we also consider removing/migrating the old fall-back key as well?

// sshSuffixesKey is the key in the config file for the SSH allowed suffixes.
sshSuffixesKey = "ssh_allowed_suffixes_first_auth"
// sshSuffixesKeyOld is the old key in the config file for the SSH allowed suffixes. It should be removed later.
sshSuffixesKeyOld = "ssh_allowed_suffixes"

Edit: I noticed there are references to allowed_ssh_suffixes_first_auth in the codebase, specifically the config_test.go file.

@nooreldeenmansour nooreldeenmansour force-pushed the docs-update-ssh-property branch from 692fee1 to d31cb0e Compare April 10, 2026 15:00
@adombeck
Copy link
Copy Markdown
Contributor

I noticed there are references to allowed_ssh_suffixes_first_auth in the codebase, specifically the config_test.go file.

That doesn't seem right. Feel free to fix that too. Thanks!

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.28%. Comparing base (d71041e) to head (14d1330).
⚠️ Report is 52 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1427      +/-   ##
==========================================
- Coverage   87.10%   80.28%   -6.83%     
==========================================
  Files          93       20      -73     
  Lines        6365      999    -5366     
  Branches      111        0     -111     
==========================================
- Hits         5544      802    -4742     
+ Misses        765      197     -568     
+ Partials       56        0      -56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nooreldeenmansour nooreldeenmansour merged commit eb75ffe into main Apr 14, 2026
11 of 12 checks passed
@nooreldeenmansour nooreldeenmansour deleted the docs-update-ssh-property branch April 14, 2026 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants