docs: update ssh configuration key to match broker.conf files#1427
Merged
nooreldeenmansour merged 2 commits intomainfrom Apr 14, 2026
Merged
docs: update ssh configuration key to match broker.conf files#1427nooreldeenmansour merged 2 commits intomainfrom
broker.conf files#1427nooreldeenmansour merged 2 commits intomainfrom
Conversation
Update the docs to match `broker.conf` files
692fee1 to
d31cb0e
Compare
adombeck
approved these changes
Apr 14, 2026
Contributor
That doesn't seem right. Feel free to fix that too. Thanks! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1427 +/- ##
==========================================
- Coverage 87.10% 80.28% -6.83%
==========================================
Files 93 20 -73
Lines 6365 999 -5366
Branches 111 0 -111
==========================================
- Hits 5544 802 -4742
+ Misses 765 197 -568
+ Partials 56 0 -56 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
denisonbarbosa
approved these changes
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the ssh property in the docs to match
broker.conffilesssh_allowed_suffixes->ssh_allowed_suffixes_first_authShould we also consider removing/migrating the old fall-back key as well?
authd/authd-oidc-brokers/internal/broker/config.go
Lines 46 to 49 in 6085fe4
Edit: I noticed there are references to
allowed_ssh_suffixes_first_authin the codebase, specifically theconfig_test.gofile.