cgo optimizations for go 1.24#809
Draft
3v1n0 wants to merge 2 commits intocanonical:mainfrom
Draft
Conversation
No code calls back into Go there so we can safely use this new directive
Memory is already checked during program execution and handled internally, so optimize generated cgo code.
3v1n0
force-pushed
the
cgo-optimizations
branch
from
62cd9b9 to
33ff784
Compare
Member
|
@3v1n0, can we close this one and come back to it later? Considering the whole SRU situation, it's gonna take a while before we get Go 1.24 in Noble, so I'd like us to tune down the amount of pull requests that we have lying around without reason. |
Contributor
Author
|
As you wish, I don't think I'll forget about, but keeping as draft as it is it shouldn't bother either, no? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mark functions with
nocallbackandnoescapefor optimization reasons when possible.Still a draft since we don't use such go version yet.