Skip to content

fix(rollingops): dynamic cluster id integration with etcd and sync lock#481

Merged
patriciareinoso merged 9 commits into
mainfrom
DPE-10181-fix-dynmic-cluster-id
May 27, 2026
Merged

fix(rollingops): dynamic cluster id integration with etcd and sync lock#481
patriciareinoso merged 9 commits into
mainfrom
DPE-10181-fix-dynmic-cluster-id

Conversation

@patriciareinoso
Copy link
Copy Markdown
Contributor

@patriciareinoso patriciareinoso commented May 21, 2026

Description

This PR fixes a couple of issues found in the rollingops library:

  1. Dynamic cluster ID integration with etcd does not work well.

Turns out that the certificates needed to connect to etcd were not created in case the cluster ID is not provided since deployment. Now they are created when the _EtcdRollingOpsBackend is instantiated.

Fix #480

  1. The sync lock had a weird behavior in case of exception raised during the execution of the critical path. Now:
  • we separate the exception handling between lock acquisition and execution of critical path
  • the certificates to communicate to etcd are not removed during relation broken with etcd, and we do not fall back to peer relation back end on relation broken. This allows the unit to still use etcd during the teardown phase.

If the relation was removed from the application and we are not in a scale down situation, the rollingops manager will automatically fallback to peer backend later because the relation would be missing

@patriciareinoso patriciareinoso changed the title fix(rollingops): dynamic cluster id integration with etcd fix(rollingops): dynamic cluster id integration with etcd and sync lock May 21, 2026
@patriciareinoso patriciareinoso merged commit 6ea37c3 into main May 27, 2026
44 of 46 checks passed
@patriciareinoso patriciareinoso deleted the DPE-10181-fix-dynmic-cluster-id branch May 27, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants