Skip to content

Add sleep key and suspend led jobs for suspend dependency (BugFix)#2419

Merged
tomli380576 merged 2 commits intomainfrom
add_dependency
Mar 30, 2026
Merged

Add sleep key and suspend led jobs for suspend dependency (BugFix)#2419
tomli380576 merged 2 commits intomainfrom
add_dependency

Conversation

@clairlin53
Copy link
Copy Markdown
Contributor

@clairlin53 clairlin53 commented Mar 24, 2026

Description

  1. Add dependency for two jobs.
  • keys/sleep
  • led/power-blink-suspend
  1. Modify the test plan and make it clearly in the after suspend test plan.
  • keys/power-button-suspend
  • keys/sleep

Resolved issues

Documentation

Tests

https://certification.canonical.com/hardware/202603-38484/submission/480327/

keys-cert-manual

Item
com.canonical.plainbox::manifest
com.canonical.certification::keys/lock-screen
com.canonical.certification::keys/super
com.canonical.certification::keys/brightness
com.canonical.certification::keys/media-control
com.canonical.certification::keys/mute
com.canonical.certification::keys/volume
com.canonical.certification::keys/video-out
com.canonical.certification::keys/wireless
com.canonical.certification::keys/keyboard-backlight
com.canonical.certification::package
com.canonical.certification::keys/microphone-mute
com.canonical.certification::keys/power-button
com.canonical.certification::keys/power-button-event
com.canonical.certification::keys/fn-lock

 
after-suspend-keys-cert-manual

Item
com.canonical.plainbox::manifest
com.canonical.certification::keys/lock-screen
com.canonical.certification::rtc
com.canonical.certification::sleep
com.canonical.certification::package
com.canonical.certification::keys/power-button-event
com.canonical.certification::keys/media-control
com.canonical.certification::keys/power-button
com.canonical.certification::keys/microphone-mute
com.canonical.certification::keys/super
com.canonical.certification::keys/wireless
com.canonical.certification::keys/video-out
com.canonical.certification::keys/volume
com.canonical.certification::keys/fn-lock
com.canonical.certification::keys/brightness
com.canonical.certification::keys/keyboard-backlight
com.canonical.certification::keys/mute
com.canonical.certification::suspend/suspend_advanced_auto
com.canonical.certification::after-suspend-keys/lock-screen
com.canonical.certification::after-suspend-keys/super
com.canonical.certification::after-suspend-keys/brightness
com.canonical.certification::after-suspend-keys/media-control
com.canonical.certification::after-suspend-keys/mute
com.canonical.certification::after-suspend-keys/volume
com.canonical.certification::after-suspend-keys/video-out
com.canonical.certification::after-suspend-keys/wireless
com.canonical.certification::after-suspend-keys/keyboard-backlight
com.canonical.certification::after-suspend-keys/microphone-mute
com.canonical.certification::after-suspend-keys/power-button
com.canonical.certification::after-suspend-keys/power-button-event
com.canonical.certification::after-suspend-keys/fn-lock
com.canonical.certification::keys/power-button-suspend
com.canonical.certification::keys/sleep

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.18%. Comparing base (f5120f9) to head (1971149).
⚠️ Report is 18 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2419   +/-   ##
=======================================
  Coverage   58.18%   58.18%           
=======================================
  Files         475      475           
  Lines       47802    47802           
  Branches     8499     8499           
=======================================
  Hits        27815    27815           
- Misses      19101    19104    +3     
+ Partials      886      883    -3     
Flag Coverage Δ
provider-base 32.63% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@clairlin53 clairlin53 marked this pull request as ready for review March 24, 2026 06:03
@clairlin53 clairlin53 changed the title Add sleep key and suspend led jobs for suspend dependency Add sleep key and suspend led jobs for suspend dependency (BugFix) Mar 24, 2026
Copy link
Copy Markdown
Contributor

@hanhsuan hanhsuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clairlin53 clairlin53 requested a review from tomli380576 March 30, 2026 03:00
Copy link
Copy Markdown
Contributor

@tomli380576 tomli380576 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tomli380576 tomli380576 merged commit 1440fc9 into main Mar 30, 2026
43 of 45 checks passed
@tomli380576 tomli380576 deleted the add_dependency branch March 30, 2026 05:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants