Implement context manager to handle codec test file download an deletion (BugFix)#2429
Merged
Conversation
rickwu666666
changed the title
rickwu666666
force-pushed
the
add-download-codec-test-files
branch
5 times, most recently
from
d4fea75 to
22a07cc
Compare
rickwu666666
force-pushed
the
add-download-codec-test-files
branch
2 times, most recently
from
201d209 to
8238731
Compare
rickwu666666
force-pushed
the
add-download-codec-test-files
branch
from
8238731 to
0cc291f
Compare
Hook25
added
the
ce-oem
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2429 +/- ##
=======================================
Coverage 58.19% 58.19%
=======================================
Files 475 475
Lines 47819 47819
Branches 8509 8509
=======================================
Hits 27828 27828
Misses 19106 19106
Partials 885 885 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
baconYao
reviewed
May 5, 2026
Contributor
baconYao
left a comment
baconYao
left a comment
There was a problem hiding this comment.
It's a good way to tackle test files, but I have some questions.
baconYao
approved these changes
May 5, 2026
Contributor
baconYao
left a comment
baconYao
left a comment
There was a problem hiding this comment.
After checking with @rickwu666666, there's no concern from me. LGTM
Contributor
Author
|
@copilot resolve the merge conflicts in this pull request |
Co-authored-by: rickwu666666 <98441647+rickwu666666@users.noreply.github.com>
Contributor
Resolved by merging latest |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement context manager to handle codec test file download and deletion
VIDEO_CODEC_TESTING_DATAis no longer mandatory. If not provided, files are stored in avideodirectory within the user's home folder. If provided, the files in that path are used as test data, and no new files are downloaded during testing if the valid file under the path.Description
Resolved issues
Documentation
Tests
Sideload result
https://pastebin.canonical.com/p/Jz5mtwvwCy/